Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for JSON meta data download #14392

Merged
merged 1 commit into from Oct 3, 2017
Merged

Fix for JSON meta data download #14392

merged 1 commit into from Oct 3, 2017

Conversation

snipem
Copy link
Contributor

@snipem snipem commented Oct 3, 2017

Added fixes according to #13651 and user @remitamine

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

The code was initially posted by user @remitamine. @remitamine Please give you approval in this Pull Request.

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

Fixes the generic extraction problem of JSON data from NBC sites by adding a prefix to the URL to be downloaded. The code was first introduced by user @remitamine in the #13651 discussion.

Added fixes according to #13651 and user @remitamine
@remitamine remitamine merged commit bfd484c into ytdl-org:master Oct 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants