Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[funimation] Add _get_subtitles #24906

Closed
wants to merge 10 commits into from
27 changes: 26 additions & 1 deletion youtube_dl/extractor/funimation.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@
int_or_none,
js_to_json,
ExtractorError,
urlencode_postdata
urlencode_postdata,
urljoin
)


Expand Down Expand Up @@ -105,6 +106,7 @@ def _search_kane(name):
if series:
title = '%s - %s' % (series, title)
description = self._html_search_meta(['description', 'og:description'], webpage, fatal=True)
subtitles = self.extract_subtitles(url, video_id, display_id)

try:
headers = {}
Expand Down Expand Up @@ -149,6 +151,29 @@ def _search_kane(name):
'season_number': int_or_none(title_data.get('seasonNum') or _search_kane('season')),
'episode_number': int_or_none(title_data.get('episodeNum')),
'episode': episode,
'subtitles': subtitles,
'season_id': title_data.get('seriesId'),
'formats': formats,
}

def _get_subtitles(self, url, video_id, display_id):
player_url = urljoin(url, '/player/' + video_id)
player_page = self._download_webpage(player_url, display_id)
text_tracks_json_string = self._search_regex(
r'"textTracks": (\[{.+?}\])',
player_page, 'subtitles data', default='')
if not text_tracks_json_string:
# Funimation player page unavailable due to robot detection.
# Don't warn so that unit tests still pass this step.
return {}
text_tracks = self._parse_json(
text_tracks_json_string, display_id, js_to_json, fatal=False) or []
subtitles = {}
for text_track in text_tracks:
url_element = {'url': text_track.get('src')}
language = text_track.get('language')
if language in subtitles:
subtitles[language].append(url_element)
else:
subtitles[language] = [url_element]
return subtitles