[funimation] Add _get_subtitles #24906
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mevious
changed the title
Mevious
changed the title
Closed
Mevious
changed the title
|
Any chance that this will get merged? |
|
Can we get a merge? |
Closed
dstftw
force-pushed
the
master
branch
2 times, most recently
from
5e26784
to
da2069f
Compare
Lukebb04
approved these changes
Feb 11, 2021
6 tasks
pukkandan
pushed a commit
to yt-dlp/yt-dlp
that referenced
this pull request
Jun 23, 2021
Closes #420, ytdl-org/youtube-dl#25645 Related: ytdl-org/youtube-dl#24906 Authored by: Mevious
nixxo
pushed a commit
to nixxo/yt-dlp
that referenced
this pull request
Nov 22, 2021
Closes yt-dlp#420, ytdl-org/youtube-dl#25645 Related: ytdl-org/youtube-dl#24906 Authored by: Mevious
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
xinto all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
Fixes #22027. This new function parses the player page associated with the video in order to find the links to subtitle files.
Unit tests were failing before I modified this file. Apparently they get caught by Funimation's robot detection. The parser still works when you provide a username/password and cookies file for an active account. I tried my best to not break the tests further than they already are by falling back to no subtitles in every error case. I validated the functionality in Python 3.7 and 2.7, but I was unable to validate python 2.6 due to the discontinuation of TLS 1.0 and 1.1. Is this still a requirement?