[Instagram] improve title extraction and add duration for IGTV #28469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brodan
changed the title
Brodan
changed the title
github-actions bot
added a commit
to hellopony/youtube-dl
that referenced
this pull request
Mar 29, 2021
* https://github.com/ytdl-org/youtube-dl: [instagram] Improve title extraction and extract duration (ytdl-org#28469)
leshasmlesha
pushed a commit
to leshasmlesha/youtube-dl
that referenced
this pull request
Apr 3, 2021
…8469) Co-authored-by: Sergey M. <dstftw@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
This PR updates the Instagram info extractor to include a
durationfield and improve how thetitlefield is set. Duration is available on the media but is not currently being returned by the info extractor. Additionally, thetitlefield is now set directly from thetitleof the video in the case of IGTV, otherwise it falls back on the existing title logic.An IGTV link has been added to the Instagram extractors tests list to cover this.