[peertube] handle new video URL format #29475
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rautamiekka
reviewed
Jul 5, 2021
| videos\.tcit\.fr| | ||
| peertube\.cpy\.re| | ||
| canard\.tube | ||
| )''' | ||
| _UUID_RE = r'[\da-fA-F]{8}-[\da-fA-F]{4}-[\da-fA-F]{4}-[\da-fA-F]{4}-[\da-fA-F]{12}' | ||
| _UUID_RE = r'[\da-zA-Z]{22}|[\da-fA-F]{8}-[\da-fA-F]{4}-[\da-fA-F]{4}-[\da-fA-F]{4}-[\da-fA-F]{12}' |
There was a problem hiding this comment.
Wouldn't this break the old UUID's, assuming old ones are still in use ?
There was a problem hiding this comment.
Hi,
No, the regex should be able to detect new "short uuids" (22 characters) or classic uuids
To prevent potential regression, I added tests that mix the new/old URLs:
pukkandan
added a commit
to yt-dlp/yt-dlp
that referenced
this pull request
Aug 23, 2021
Closes #722, ytdl-org/youtube-dl#29782 Original PR: ytdl-org/youtube-dl#29475 Authored by: Chocobozzz
Lesmiscore
added a commit
to ytdl-patched/ytdl-patched
that referenced
this pull request
Aug 23, 2021
* 'master' of https://github.com/yt-dlp/yt-dlp: [peertube] handle new video URL format Closes #722, ytdl-org/youtube-dl#29782 Original PR: ytdl-org/youtube-dl#29475 Authored by: Chocobozzz [adobepass] Fix Verizon SAML login (#743) Fix `add_info_extractor` when used via API Bug from: 251ae04 [lazy_extractor] Create instance only after pre-checking archive [lazy_extractor] Import actual class if an attribute is accessed [extractor] Show video id in error messages if possible [extractor] Better error message for DRM (#729) [youtube] Add av01 itags to known formats list (#747) [bitchute] Fix test (#758) [lazy_extractors] Fix `suitable` and add flake8 test [utils] Add `parse_qs` [youtube] Add `shorts` to `_VALID_URL` Normally the generic extractor will redirect the URL, but the cookies consent screen may sometimes appear instead Don't try to merge with final extension [extractor] Common function `_match_valid_url`
nixxo
pushed a commit
to nixxo/yt-dlp
that referenced
this pull request
Nov 22, 2021
Closes yt-dlp#722, ytdl-org/youtube-dl#29782 Original PR: ytdl-org/youtube-dl#29475 Authored by: Chocobozzz
11 tasks
9 tasks
|
Hey, just patched it against the latest in pypi and it works :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
xinto all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
/w/instead of/videos/watch) that will be released in 3.3 (https://github.com/Chocobozzz/PeerTube/blob/develop/CHANGELOG.md)og:platform(unofficial) opengraph tag