Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix XSRF token logon to vrtnu #29614

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

pgaig
Copy link

@pgaig pgaig commented Jul 22, 2021

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

Gets the new required CSRF (aka XSRF) cookie / header to pass the logon of the vrtnu extractor

resolves #29534, resolves #29044

@michaelpeeters
Copy link

works for me.

@SamDecrock
Copy link

Works for me too. Thanks.

SamDecrock pushed a commit to SamDecrock/yt-dlp that referenced this pull request Jul 29, 2021
@xplorr
Copy link

xplorr commented Aug 2, 2021

Works perfect here! Thx!

pukkandan pushed a commit to yt-dlp/yt-dlp that referenced this pull request Aug 3, 2021
@BelgianNoise
Copy link

Can we get this in the next release ?

@MatthiasCoppens
Copy link

Works for me! (Gentoo Linux, Python 3.9)

@pgaig
Copy link
Author

pgaig commented Aug 18, 2021

Has anyone advice on how to get this fix merged? In the meantime, the forked yt-dlp has this fix incorporated.
Not sure what the next step is (seems to be blocked on 1 workflow awaiting approval -- First-time contributors need a maintainer to approve running workflows).

@xplorr
Copy link

xplorr commented Aug 18, 2021

I have compiled a windows exe which has this fix merged. If you want, I can send you the link.

@MatthiasCoppens
Copy link

I pinged the devs on IRC

@bertvandepoel
Copy link

I can also confirm that this works! I'm on Ubuntu 18.04 with Python 3.6.9

@BelgianNoise
Copy link

bump, if this even has any effect

@MatthiasCoppens
Copy link

At this point I switched to https://github.com/yt-dlp/yt-dlp, it's a shame youtube-dl has gone downhill. yt-dlp is in the AUR for Arch users and in the official repo for Gentoo users.

@BelgianNoise
Copy link

Im gonna have grandkids before this gets merged...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
7 participants