Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Paramount+] Back-port Paramount+ extractor (etc) from yt-dlp #30085

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dirkf
Copy link
Contributor

@dirkf dirkf commented Oct 11, 2021

Please follow the guide below


Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

The structure of pages at paramountplus.com has changed, as well that of some pages handled by other extractor modules such as cbs.py and theplatform.py.

This PR back-ports the required changes from yt-dlp , with some small changes to match the platform and API. ParamountPlus and ParamountPlusSeries extractors are added, with supporting changes to CBS and ThePlatform extractors.

A _match_valid_url() method is included in the ThePlatformBaseIE class, which can be removed if PR #30046 has been merged.

The PR is expected (as far as possible) to

The tests needed to be run in the USA before merging, as the ParamountPlus URLs are strongly geo-blocked. The CI runs seem to have passed that check.

Thanks @dodrian, @Sipherdrakon for additional updates from yt-dlp.

@dirkf dirkf force-pushed the dlp-paramountplus-patch branch 3 times, most recently from 9dbb225 to 62b447f Compare October 11, 2021 19:32
With supporting changes to CBS and ThePlatform extractors
@hbiede
Copy link

hbiede commented Apr 9, 2022

I would certainly love to see this issue resolved

@dirkf
Copy link
Contributor Author

dirkf commented Apr 12, 2022

Looks like some that fails with this patch:

#29351
#29038

You identified the second as DRM. I would think that something as astonishingly desirable as "rupaul-s-drag-race-drama-queens" (in the first issue) might also be protected? In the UK they all look the same as ERROR: Unable to download JSON metadata: HTTP Error 403: Forbidden

From yt-dlp/yt-dlp#3098

Authored by: Sipherdrakon
@dodrian
Copy link

dodrian commented Apr 13, 2022

Looks like some that fails with this patch:
#29351
#29038

You identified the second as DRM. I would think that something as astonishingly desirable as "rupaul-s-drag-race-drama-queens" (in the first issue) might also be protected? In the UK they all look the same as ERROR: Unable to download JSON metadata: HTTP Error 403: Forbidden

All movies are DRMed, and in my experience some TV shows are DRMed as well - even to the point where some episodes are DRM and some are not in the same season.

@Sipherdrakon
Copy link

Sipherdrakon commented Apr 13, 2022 via email

@dirkf
Copy link
Contributor Author

dirkf commented Apr 14, 2022

So should we take out the URL match for movies and/or add an explicit check for DRM?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants