Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rbgtum] Add new extractor #31305

Merged
merged 2 commits into from
Feb 9, 2023
Merged

[rbgtum] Add new extractor #31305

merged 2 commits into from
Feb 9, 2023

Conversation

Valentin-Metz
Copy link
Contributor

@Valentin-Metz Valentin-Metz commented Oct 22, 2022

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

New extractor for https://live.rbg.tum.de/ lecture streaming site.
This supersedes, closes #27362.

Copy link
Contributor

@dirkf dirkf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work!

Is this extractor going to be generally useful, or only for the institution concerned? If TUM is publishing educational media for public use we have no problem integrating the extractor?

I've made some suggestions for the code.

youtube_dl/extractor/rbgtum.py Show resolved Hide resolved
youtube_dl/extractor/rbgtum.py Outdated Show resolved Hide resolved
youtube_dl/extractor/rbgtum.py Outdated Show resolved Hide resolved
youtube_dl/extractor/rbgtum.py Show resolved Hide resolved
youtube_dl/extractor/rbgtum.py Outdated Show resolved Hide resolved
@Valentin-Metz
Copy link
Contributor Author

All lectures you see on https://live.rbg.tum.de/ are publicly available.
(Although there are some additional private courses which require an account / a valid --cookies file)
I'd consider the publicly available courses useful for a general audience.

@Valentin-Metz
Copy link
Contributor Author

This should be ready for merge.
In case I should change anything else, let me know.

@dirkf dirkf merged commit 80c0228 into ytdl-org:master Feb 9, 2023
github-actions bot added a commit to hellopony/youtube-dl that referenced this pull request Feb 9, 2023
* https://github.com/ytdl-org/youtube-dl:
  [rbgtum] Add new extractor (ytdl-org#31305)
  [YouTube] Fix tests
  [YouTube] Refresh compat/utils usage * import parse_qs() * import parse_qs in lazy_extractors (clears old TODO) * clean up old compiled lazy_extractors for Py2 * use update_url()
  [compat] Update test_compat
  [utils] Add parse_qs, update_url
  [compat] Systematise compat_ naming
  [test] Fix TestAgeRestriction
  [YouTube] Add `signatureTimestamp` for age-gate bypass
  [YouTube] Bypass age-gating for certain restricted videos
dirkf added a commit that referenced this pull request Feb 13, 2023
* [rbgtum] Add new extractor

* Small update, force CI

---------

Co-authored-by: dirkf <fieldhouse@gmx.net>
github-actions bot added a commit to hellopony/youtube-dl that referenced this pull request Feb 13, 2023
* https://github.com/ytdl-org/youtube-dl:
  [StreamsbIE] Add extractor for streamsb.com (viewsb.com) (ytdl-org#31517)
  [KommunetvIE] Add extractor for kommunetv.no (ytdl-org#31516)
  [FileMoonIE] Add extractor for filemoon.sx (ytdl-org#31515)
  [feat]: Add support to external downloader aria2p (ytdl-org#31500)
  [rbgtum] Add new extractor (ytdl-org#31305)
  [YouTube] Fix tests
  [YouTube] Refresh compat/utils usage * import parse_qs() * import parse_qs in lazy_extractors (clears old TODO) * clean up old compiled lazy_extractors for Py2 * use update_url()
  [compat] Update test_compat
  [utils] Add parse_qs, update_url
  [compat] Systematise compat_ naming
  [test] Fix TestAgeRestriction
  [YouTube] Add `signatureTimestamp` for age-gate bypass
  [YouTube] Bypass age-gating for certain restricted videos
  [Vimeo] Support /user{video_id}/{slug} URL format
  [Vimeo] Fix `Unable to extract info section` redux * as reported in yt-dlp/yt-dlp#6149 * also allow newline in target JSON object
  [jsinterp] Nits
  [IGN] Overhaul extractor to avoid URL redirection loop
alxlive pushed a commit to alxlive/youtube-dl that referenced this pull request Feb 27, 2023
* [rbgtum] Add new extractor

* Small update, force CI

---------

Co-authored-by: dirkf <fieldhouse@gmx.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants