Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FileMoonIE] Add extractor for filemoon.sx #31515

Merged
merged 3 commits into from
Feb 11, 2023
Merged

Conversation

fonkap
Copy link
Contributor

@fonkap fonkap commented Feb 6, 2023

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

Adds support for filemoon.sx

Resolves #31126

Copy link
Contributor

@dirkf dirkf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work!

I've made some suggestions though probably can't all be committed without some more tweaks.

youtube_dl/extractor/filemoon.py Outdated Show resolved Hide resolved
youtube_dl/extractor/filemoon.py Outdated Show resolved Hide resolved
youtube_dl/extractor/filemoon.py Outdated Show resolved Hide resolved
youtube_dl/extractor/filemoon.py Outdated Show resolved Hide resolved
youtube_dl/extractor/filemoon.py Outdated Show resolved Hide resolved
youtube_dl/extractor/filemoon.py Outdated Show resolved Hide resolved
Co-authored-by: dirkf <fieldhouse@gmx.net>
Copy link
Contributor Author

@fonkap fonkap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I applied all changes and they work fine.
Thanks @dirkf !

@fonkap fonkap requested a review from dirkf February 7, 2023 08:39
Copy link
Contributor

@dirkf dirkf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some simplification. I'm happy to apply these if you want and merge if CI tests are OK.

youtube_dl/extractor/filemoon.py Outdated Show resolved Hide resolved
youtube_dl/extractor/filemoon.py Outdated Show resolved Hide resolved
youtube_dl/extractor/filemoon.py Outdated Show resolved Hide resolved
youtube_dl/extractor/filemoon.py Outdated Show resolved Hide resolved
Co-authored-by: dirkf <fieldhouse@gmx.net>
Copy link
Contributor Author

@fonkap fonkap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes applied and working fine.
You were right! thanks

@dirkf dirkf merged commit cf5fb7e into ytdl-org:master Feb 11, 2023
github-actions bot added a commit to hellopony/youtube-dl that referenced this pull request Feb 11, 2023
* https://github.com/ytdl-org/youtube-dl:
  [StreamsbIE] Add extractor for streamsb.com (viewsb.com) (ytdl-org#31517)
  [KommunetvIE] Add extractor for kommunetv.no (ytdl-org#31516)
  [FileMoonIE] Add extractor for filemoon.sx (ytdl-org#31515)
dirkf added a commit that referenced this pull request Feb 13, 2023
---------

Co-authored-by: dirkf <fieldhouse@gmx.net>
github-actions bot added a commit to hellopony/youtube-dl that referenced this pull request Feb 13, 2023
* https://github.com/ytdl-org/youtube-dl:
  [StreamsbIE] Add extractor for streamsb.com (viewsb.com) (ytdl-org#31517)
  [KommunetvIE] Add extractor for kommunetv.no (ytdl-org#31516)
  [FileMoonIE] Add extractor for filemoon.sx (ytdl-org#31515)
  [feat]: Add support to external downloader aria2p (ytdl-org#31500)
  [rbgtum] Add new extractor (ytdl-org#31305)
  [YouTube] Fix tests
  [YouTube] Refresh compat/utils usage * import parse_qs() * import parse_qs in lazy_extractors (clears old TODO) * clean up old compiled lazy_extractors for Py2 * use update_url()
  [compat] Update test_compat
  [utils] Add parse_qs, update_url
  [compat] Systematise compat_ naming
  [test] Fix TestAgeRestriction
  [YouTube] Add `signatureTimestamp` for age-gate bypass
  [YouTube] Bypass age-gating for certain restricted videos
  [Vimeo] Support /user{video_id}/{slug} URL format
  [Vimeo] Fix `Unable to extract info section` redux * as reported in yt-dlp/yt-dlp#6149 * also allow newline in target JSON object
  [jsinterp] Nits
  [IGN] Overhaul extractor to avoid URL redirection loop
alxlive pushed a commit to alxlive/youtube-dl that referenced this pull request Feb 27, 2023
---------

Co-authored-by: dirkf <fieldhouse@gmx.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

https://filemoon.sx/
2 participants