-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FileMoonIE] Add extractor for filemoon.sx #31515
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work!
I've made some suggestions though probably can't all be committed without some more tweaks.
Co-authored-by: dirkf <fieldhouse@gmx.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I applied all changes and they work fine.
Thanks @dirkf !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some simplification. I'm happy to apply these if you want and merge if CI tests are OK.
Co-authored-by: dirkf <fieldhouse@gmx.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All changes applied and working fine.
You were right! thanks
* https://github.com/ytdl-org/youtube-dl: [StreamsbIE] Add extractor for streamsb.com (viewsb.com) (ytdl-org#31517) [KommunetvIE] Add extractor for kommunetv.no (ytdl-org#31516) [FileMoonIE] Add extractor for filemoon.sx (ytdl-org#31515)
--------- Co-authored-by: dirkf <fieldhouse@gmx.net>
* https://github.com/ytdl-org/youtube-dl: [StreamsbIE] Add extractor for streamsb.com (viewsb.com) (ytdl-org#31517) [KommunetvIE] Add extractor for kommunetv.no (ytdl-org#31516) [FileMoonIE] Add extractor for filemoon.sx (ytdl-org#31515) [feat]: Add support to external downloader aria2p (ytdl-org#31500) [rbgtum] Add new extractor (ytdl-org#31305) [YouTube] Fix tests [YouTube] Refresh compat/utils usage * import parse_qs() * import parse_qs in lazy_extractors (clears old TODO) * clean up old compiled lazy_extractors for Py2 * use update_url() [compat] Update test_compat [utils] Add parse_qs, update_url [compat] Systematise compat_ naming [test] Fix TestAgeRestriction [YouTube] Add `signatureTimestamp` for age-gate bypass [YouTube] Bypass age-gating for certain restricted videos [Vimeo] Support /user{video_id}/{slug} URL format [Vimeo] Fix `Unable to extract info section` redux * as reported in yt-dlp/yt-dlp#6149 * also allow newline in target JSON object [jsinterp] Nits [IGN] Overhaul extractor to avoid URL redirection loop
--------- Co-authored-by: dirkf <fieldhouse@gmx.net>
Please follow the guide below
x
into all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
Adds support for filemoon.sx
Resolves #31126