Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.MD #31488

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Update README.MD #31488

wants to merge 1 commit into from

Conversation

K-web04
Copy link

@K-web04 K-web04 commented Jan 23, 2023

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

Explanation of your pull request in arbitrary form goes here. Please make sure the description explains the purpose and effect of your pull request and is worded well enough to be understood. Provide as much context and examples as possible.

@@ -18,7 +18,7 @@ youtube-dl - download videos from youtube.com or other video platforms

# INSTALLATION

To install it right away for all UNIX users (Linux, macOS, etc.), type:
To install it right away for all UNIX users (Windows,Linux, macOS, etc.), type:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would have to be:

Suggested change
To install it right away for all UNIX users (Windows,Linux, macOS, etc.), type:
To install it right away for all users (Windows, Linux, macOS, etc.), type:

@dirkf
Copy link
Contributor

dirkf commented Jan 23, 2023

Feel free to complete the description in the PR template.

The proposed change would only be valid if there was a sudo program in Windows, which there certainly wasn't when the text was written and AFAIK this is still true.

There is now a usable Windows Subsystem for Linux with a sudo command. If you can demonstrate installing yt-dl release in WSL using the procedure laid out for Unixes, we might consider something like this:

 To install it right away for all UNIX users (Linux, macOS, etc.), type:

 sudo curl -L https://yt-dl.org/downloads/latest/youtube-dl -o /usr/local/bin/youtube-dl
 sudo chmod a+rx /usr/local/bin/youtube-dl

 If you do not have curl, you can alternatively use a recent wget:

 sudo wget https://yt-dl.org/downloads/latest/youtube-dl -O /usr/local/bin/youtube-dl
 sudo chmod a+rx /usr/local/bin/youtube-dl

-Windows users can download an .exe file and place it in any location on their PATH except for %SYSTEMROOT%\System32 (e.g. do not put in C:\Windows\System32).
+You can also use this procedure in Windows Subsystem for Linux. Otherwise Windows users can download an .exe file and place it in any location on their PATH except for %SYSTEMROOT%\System32 (e.g. do not put in C:\Windows\System32).

My guess is that the WSL installation procedure doesn't put the program on the PATH for ordinary Windows use but I'd be happy to receive advice from someone like the owner (@ethanhs) of this repo which reports "works perfectly".

@dirkf dirkf marked this pull request as draft April 5, 2023 23:48
@angelobguido

This comment was marked as off-topic.

@dirkf

This comment was marked as resolved.

@rautamiekka
Copy link
Contributor

"sudo youtube-dl"

NEVER DO THAT !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants