Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made the YouTubeIE regex verbose/commented #403

Merged
merged 1 commit into from
Sep 29, 2012

Conversation

FiloSottile
Copy link
Collaborator

This might be useful both to regex beginners (our regex is incredibly complete of language features!) and to new contributors.
Pretty sure i haven't broke it ;)

See http://www.regular-expressions.info/freespacing.html and https://gist.github.com/2176911

@FiloSottile
Copy link
Collaborator Author

@phihag I know I am pushing out a number of pull requests that will be a nightmare to merge, so simply give me the OK on the ones you think and I will do the merging :)

@phihag
Copy link
Contributor

phihag commented Sep 27, 2012

This one needs to be updated, and you're welcome to treat the current regexp to this. I'm not sure why def suitable is added here though.

@FiloSottile
Copy link
Collaborator Author

Ok, great, will do ASAP.

A change to that function was needed to add the re.VERBOSE flag; there were two ways to do that, changing the main suitable func, but that could lead to strange surprises with other regexs containing #'s, or by hacking it in YouTubeIE. Hope it is not a too ugly fix.

@ghost ghost assigned FiloSottile Sep 27, 2012
@FiloSottile FiloSottile merged commit 202e76c into ytdl-org:master Sep 29, 2012
joedborg referenced this pull request in joedborg/youtube-dl Nov 17, 2020
[pull] master from ytdl-org:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants