-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Treefrog frontend fixes #95
Conversation
Thanks for your patience - I am testing this out now. Will report back |
I can report back on the UX for reading these treefrog files - everything seems to work fine. I followed instructions from the previous issue on adding Enhancement
Minor comments:
Would it be possible to provide a more helpful message by saying “You have provided the raw data file but I am expecting the foreststats file” or just helpfully inferring the Unrelated issue:The docs https://ytree.readthedocs.io/en/latest/Arbor.html#getting-started-with-merger-trees do not reflect what I see. For example, with
|
I'm not sure about how to do this efficiently. In
I'll see what I can do about this. It's tricky because we support many different formats using HDF5 data. It takes being able to distinguish a file is of a specific format while not the correct file for that format.
What you're seeing here is the difference between the Thanks for the feedback. Rather than continuing to iterate on this PR, I will merge this and open issues for the enhancements you requested. We can continue to discuss there. |
Thanks for the explanation - and yup sounds good. Thanks again for implementing this format :) |
PR Summary
For comments on PR #88.
PR Checklist