Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebranded (hardware compatibile) devices #1698

Merged
merged 2 commits into from
Feb 1, 2019
Merged

Rebranded (hardware compatibile) devices #1698

merged 2 commits into from
Feb 1, 2019

Conversation

pedjaj
Copy link
Contributor

@pedjaj pedjaj commented Jan 28, 2019

Pre-Request Checklist

  • Passes rubocop code analysis (try rubocop --auto-correct)
  • Tests added or adapted (try rake test)
  • Changes are reflected in the documentation
  • User-visible changes appended to CHANGELOG.md

Description

  • Allied Telesis AT-8000s and AT-8000GS series switches are RADLAN switches, same as powerconnect and can use powerconnect.rb model.
  • TP-link switch TL-SL5428 (not JetStream) with Marvell 98DX106-B0, 88E6095[F] same as EdgeCore - ES352x or SMC TigerSwitch 10/100 SMC6128L2 Manager and can use edgecos.rb model
  • TP-link switch TL-SL3428 can use powerconnect.rb model.

@codecov-io
Copy link

codecov-io commented Jan 28, 2019

Codecov Report

Merging #1698 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1698   +/-   ##
=======================================
  Coverage   62.62%   62.62%           
=======================================
  Files          30       30           
  Lines        1493     1493           
=======================================
  Hits          935      935           
  Misses        558      558

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b021e33...125c908. Read the comment docs.

Tp-link TL-SL3428 works with powerconnect.rb model.
@wk
Copy link
Contributor

wk commented Feb 1, 2019

Thanks for sending this in; I'll pull it as-is, but when abstracting away models, it can be quite valuable to try and determine the actual name of the underlying OS type.

For example, if the 'Dell PowerConnect' devices actually run 'RADLAN OS', it might be worth the effort to rename the powerconnect.rb model to radlan.rb, create a temporary shim for the 'powerconnect.rb' model (see here for an example), and document this change.

This allows a clearer and more correct view of which OS types are supported, and eases maintenance and matching of new devices.

@wk wk merged commit 4ef1fa1 into ytti:master Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants