Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hidden info for SonicWall #1938

Merged
merged 2 commits into from
Jan 19, 2020
Merged

Add hidden info for SonicWall #1938

merged 2 commits into from
Jan 19, 2020

Conversation

s-fu
Copy link
Contributor

@s-fu s-fu commented Oct 15, 2019

Pre-Request Checklist

  • Passes rubocop code analysis (try rubocop --auto-correct)
  • Tests added or adapted (try rake test)
  • Changes are reflected in the documentation
  • User-visible changes appended to CHANGELOG.md

Description

Sensitive information also exists in the following lines. Mark then in hidden secret module.

  • password xxx
  • passphrase password xxx
  • bind-password xxx
  • authenticate sha1 xxx
  • encryption aes xxx

@codecov-io
Copy link

codecov-io commented Oct 15, 2019

Codecov Report

Merging #1938 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1938   +/-   ##
=======================================
  Coverage   63.32%   63.32%           
=======================================
  Files          30       30           
  Lines        1497     1497           
=======================================
  Hits          948      948           
  Misses        549      549

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e9324c...e17e81c. Read the comment docs.

@wk wk merged commit ca54d6a into ytti:master Jan 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants