Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MikroTik SwOS Model #2674

Merged
merged 1 commit into from
Dec 3, 2022
Merged

MikroTik SwOS Model #2674

merged 1 commit into from
Dec 3, 2022

Conversation

sm-nessus
Copy link
Contributor

Pre-Request Checklist

  • Passes rubocop code analysis (try rubocop --auto-correct)
    RuboCop on Ubuntu 22.04 doesn't support Ruby 2.3:
Error: RuboCop found unsupported Ruby version 2.3 in `TargetRubyVersion` parameter (in .rubocop.yml). 2.3-compatible analysis was dropped after version 0.81.
Supported versions: 2.4, 2.5, 2.6, 2.7, 2.8

Please let me know how to proceed, whether I need to downgrade RuboCop, or you want to change the target version (or if the analysis is not needed).

  • Tests added or adapted (try rake test)
    I haven't found any model tests, please let me know if I missed it or if there are no tests for models.
  • Changes are reflected in the documentation
  • User-visible changes appended to CHANGELOG.md

Description

Added support for MikroTik SwOS Lite and most likely for other SwOS versions. I only have a SwOS Lite device, which I've tested against.

I have no experience with Ruby, so I've adapted the code from the "Zyxel OLTs series 1308" model (zy1308.rb).

Please let me know if there are any issues.

Thanks!

@mortzu mortzu merged commit 3d4444a into ytti:master Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants