fix rubocop warnings #2738
Merged
fix rubocop warnings #2738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
down to 7 offenses 🚀 |
|
Now we are down to not working tests. |
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #2738 +/- ##
==========================================
+ Coverage 63.28% 66.40% +3.11%
==========================================
Files 30 30
Lines 1498 1500 +2
==========================================
+ Hits 948 996 +48
+ Misses 550 504 -46
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
aschaber1
force-pushed
the
rubocop-fixes
branch
2 times, most recently
from
240fb8f
to
9880db2
Compare
|
Can I merge? |
|
@mortzu , should I rebase (and reduce number of commits) first? I tried to have atomic commits, which turned out to be quiet a few. There are a few tests I had to skip, because my ruby skills are not good enough to fix them. let me update the readme that it now requires ruby >= 3 besides that, I'm happily running this for the last couple of weeks. |
|
README and CHANGELOG updated :) I'm fine now. |
aschaber1
force-pushed
the
rubocop-fixes
branch
from
98667bb
to
43a5c0a
Compare
Metrics/ParameterLists: Avoid parameter lists longer than 5 parameters. [6/5]
Metrics/ClassLength: Class has too many lines. [197/192]
…it is implied by default
…xity for oxidized_expect is too high. [13/12]
… at block body end
aschaber1
force-pushed
the
rubocop-fixes
branch
from
43a5c0a
to
51e2f5a
Compare
|
@mortzu you can merge now, thank you :) added a test to make sure all quality targets are hit :) |
|
🎉 |
nickhilliard
pushed a commit
to nickhilliard/oxidized
that referenced
this pull request
Jun 15, 2023
* fix: rubocop warnings * feat: fix more problems * feat!: upgrade ruby version to 3.0 * build: update github actions * ci(ruby): update save-state to new format https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ * build: only build ruby 3.0+ * fix: rubocop fixes * fix: rubocop fixes * refactor: move from ENV for home to Dir.home * feat: upgrade dependencies * refactor: Lint/MissingSuper: Call super to initialize state of the parent class * style: avoid error by pushing Metrics/ParameterLists to 6 Metrics/ParameterLists: Avoid parameter lists longer than 5 parameters. [6/5] * refactor: various `rubocop -A` fixes * style: avoid error by pushing Metrics/ClassLength to 200 Metrics/ClassLength: Class has too many lines. [197/192] * refactor: rubocop autocorrect lib/oxidized/input/telnet.rb * build: add `rubocop-rake` and `rubocop-minitest` to `.rubocop.yml` * docs(Rakefile): add task description for task `version_set` * refactor(spec): fix Minitest/GlobalExpectations rubocop-minitest messages * ci: update ci pipeline to new codecov action * build: downgrade bundler dependency for ruby 3.0 * refactor: except Lint/DuplicateBranch: Duplicate branch body detected * refactor: fix Lint/DuplicateBranch: Duplicate branch body detected * refactor: fix Style/RedundantArgument: Argument is redundant because it is implied by default * refactor: Style/RedundantInitialize: Remove unnecessary empty initialize method * refactor: exception for Metrics/PerceivedComplexity: Perceived complexity for oxidized_expect is too high. [13/12] * refactor: Layout/EmptyLinesAroundBlockBody: Extra empty line detected at block body end * refactor: allow Lint/EmptyBlock * test(input/ssh_spec): ament `forward_agent = false` to test, to comply with code * refactor(rubocop): move some exceptions from rubocop to rubocop_todo * refactor: Lint/MissingSuper: Call super to initialize state of the parent class * build: generate codecov even if build failed * build: integrate rubocop results into pull request * build: fix versions for rubocop linter * build(ruby): enable `GITHUB_TOKEN` for `ubocop-linter-action` * build(ruby): try another rubocop action * build(ruby): change rubocop action reporter to `github-pr-review` * test(input/githubrepo_spec): fix rubocop problems * test(input/githubrepo_spec): skip tests for now * docs: upgrade install docs to ruby 3 * fix(Oxidized::String): fails when strings are empty + tests * build: add html output for non-CI builds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Request Checklist
rubocop --auto-correct)rake test)Description
I tried to fix rubocop issues. There might be more to come.