Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix rubocop warnings #2738

Merged
merged 41 commits into from
Apr 12, 2023
Merged

fix rubocop warnings #2738

merged 41 commits into from
Apr 12, 2023

Commits on Apr 11, 2023

  1. fix: rubocop warnings

    @aschaber1
    aschaber1 committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    3010bc7 View commit details
    Browse the repository at this point in the history

  2. feat: fix more problems

    @aschaber1
    aschaber1 committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    26742c1 View commit details
    Browse the repository at this point in the history

  3. feat!: upgrade ruby version to 3.0

    @aschaber1
    aschaber1 committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    b98975d View commit details
    Browse the repository at this point in the history

  4. build: update github actions

    @aschaber1
    aschaber1 committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    7b25200 View commit details
    Browse the repository at this point in the history

  5. ci(ruby): update save-state to new format 

    https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
    @aschaber1
    aschaber1 committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    5906f63 View commit details
    Browse the repository at this point in the history

  6. build: only build ruby 3.0+

    @aschaber1
    aschaber1 committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    1074b33 View commit details
    Browse the repository at this point in the history

  7. fix: rubocop fixes

    @aschaber1
    aschaber1 committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    21c3e8b View commit details
    Browse the repository at this point in the history

  8. fix: rubocop fixes

    @aschaber1
    aschaber1 committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    79e1c8a View commit details
    Browse the repository at this point in the history

  9. refactor: move from ENV for home to Dir.home

    @aschaber1
    aschaber1 committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    36c3e97 View commit details
    Browse the repository at this point in the history

  10. feat: upgrade dependencies

    @aschaber1
    aschaber1 committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    d01cb89 View commit details
    Browse the repository at this point in the history

  11. refactor: Lint/MissingSuper: Call super to initialize state of the pa… 

    …rent class
    @aschaber1
    aschaber1 committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    a95770e View commit details
    Browse the repository at this point in the history

  12. style: avoid error by pushing Metrics/ParameterLists to 6 

    Metrics/ParameterLists: Avoid parameter lists longer than 5 parameters. [6/5]
    @aschaber1
    aschaber1 committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    012d095 View commit details
    Browse the repository at this point in the history

  13. refactor: various rubocop -A fixes

    @aschaber1
    aschaber1 committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    587fff3 View commit details
    Browse the repository at this point in the history

  14. style: avoid error by pushing Metrics/ClassLength to 200 

    Metrics/ClassLength: Class has too many lines. [197/192]
    @aschaber1
    aschaber1 committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    f853a14 View commit details
    Browse the repository at this point in the history

  15. refactor: rubocop autocorrect lib/oxidized/input/telnet.rb

    @aschaber1
    aschaber1 committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    fa865e4 View commit details
    Browse the repository at this point in the history

  16. build: add rubocop-rake and rubocop-minitest to .rubocop.yml

    @aschaber1
    aschaber1 committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    d0f482f View commit details
    Browse the repository at this point in the history

  17. docs(Rakefile): add task description for task version_set

    @aschaber1
    aschaber1 committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    c2c8ba2 View commit details
    Browse the repository at this point in the history

  18. refactor(spec): fix Minitest/GlobalExpectations rubocop-minitest mess… 

    …ages
    @aschaber1
    aschaber1 committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    737c4ea View commit details
    Browse the repository at this point in the history

  19. ci: update ci pipeline to new codecov action

    @aschaber1
    aschaber1 committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    a1a159d View commit details
    Browse the repository at this point in the history

  20. build: downgrade bundler dependency for ruby 3.0

    @aschaber1
    aschaber1 committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    2915ba7 View commit details
    Browse the repository at this point in the history

  21. refactor: except Lint/DuplicateBranch: Duplicate branch body detected

    @aschaber1
    aschaber1 committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    196523e View commit details
    Browse the repository at this point in the history

  22. refactor: fix Lint/DuplicateBranch: Duplicate branch body detected

    @aschaber1
    aschaber1 committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    90c6ccc View commit details
    Browse the repository at this point in the history

  23. refactor: fix Style/RedundantArgument: Argument is redundant because … 

    …it is implied by default
    @aschaber1
    aschaber1 committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    8d860f9 View commit details
    Browse the repository at this point in the history

  24. refactor: Style/RedundantInitialize: Remove unnecessary empty initial… 

    …ize method
    @aschaber1
    aschaber1 committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    2e223c4 View commit details
    Browse the repository at this point in the history

  25. refactor: exception for Metrics/PerceivedComplexity: Perceived comple… 

    …xity for oxidized_expect is too high. [13/12]
    @aschaber1
    aschaber1 committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    8f95331 View commit details
    Browse the repository at this point in the history

  26. refactor: Layout/EmptyLinesAroundBlockBody: Extra empty line detected… 

    … at block body end
    @aschaber1
    aschaber1 committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    936892b View commit details
    Browse the repository at this point in the history

  27. refactor: allow Lint/EmptyBlock

    @aschaber1
    aschaber1 committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    5c19162 View commit details
    Browse the repository at this point in the history

  28. test(input/ssh_spec): ament forward_agent = false to test, to compl… 

    …y with code
    @aschaber1
    aschaber1 committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    96f8de7 View commit details
    Browse the repository at this point in the history

  29. refactor(rubocop): move some exceptions from rubocop to rubocop_todo

    @aschaber1
    aschaber1 committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    9329a60 View commit details
    Browse the repository at this point in the history

  30. refactor: Lint/MissingSuper: Call super to initialize state of the pa… 

    …rent class
    @aschaber1
    aschaber1 committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    fc089cb View commit details
    Browse the repository at this point in the history

  31. build: generate codecov even if build failed

    @aschaber1
    aschaber1 committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    9e74e38 View commit details
    Browse the repository at this point in the history

  32. build: integrate rubocop results into pull request

    @aschaber1
    aschaber1 committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    11b94f5 View commit details
    Browse the repository at this point in the history

  33. build: fix versions for rubocop linter

    @aschaber1
    aschaber1 committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    699a3c5 View commit details
    Browse the repository at this point in the history

  34. build(ruby): enable GITHUB_TOKEN for ubocop-linter-action

    @aschaber1
    aschaber1 committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    ca76ebc View commit details
    Browse the repository at this point in the history

  35. build(ruby): try another rubocop action

    @aschaber1
    aschaber1 committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    eaacdc1 View commit details
    Browse the repository at this point in the history

  36. build(ruby): change rubocop action reporter to github-pr-review

    @aschaber1
    aschaber1 committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    c25a27a View commit details
    Browse the repository at this point in the history

  37. test(input/githubrepo_spec): fix rubocop problems

    @aschaber1
    aschaber1 committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    ef78ebf View commit details
    Browse the repository at this point in the history

  38. test(input/githubrepo_spec): skip tests for now

    @aschaber1
    aschaber1 committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    bc224bd View commit details
    Browse the repository at this point in the history

  39. docs: upgrade install docs to ruby 3

    @aschaber1
    aschaber1 committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    51e2f5a View commit details
    Browse the repository at this point in the history

  40. fix(Oxidized::String): fails when strings are empty + tests

    @aschaber1
    aschaber1 committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    409f53e View commit details
    Browse the repository at this point in the history

  41. build: add html output for non-CI builds

    @aschaber1
    aschaber1 committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    8f9137b View commit details
    Browse the repository at this point in the history