Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor bisecting k-means #4

Merged
merged 1 commit into from
Nov 9, 2015

Conversation

mengxr
Copy link

@mengxr mengxr commented Nov 9, 2015

@yu-iskw This PR contains the refactoring code based on our offline discussion.

@yu-iskw
Copy link
Owner

yu-iskw commented Nov 9, 2015

LGTM, merging this. Thank you for this!

I think we still have a few points to discuss. As you suggested, these should be supported in Spark 1.7. One important thing is that we should design the fist commit to leave room for improvement. We can modify that without changing the top-level API.

  • Support other distance metrics
    • ex) Some NLP guys requested me to support cosine distance
  • Support other costs to evaluate the clusters, such as entropy, instead of average costs
  • Export the dendrogram
    • ex) adjacency list, linkage matrix
  • Calculate dendrogram distance between two leaf clusters
  • Find the best k by cutting a cluster tree without recomputation

yu-iskw added a commit that referenced this pull request Nov 9, 2015
Refactor bisecting k-means
@yu-iskw yu-iskw merged commit 75ca2a0 into yu-iskw:new-hierarchical-clustering Nov 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants