[yugabyte/yugabyte-db#20243] Fix regression in streaming colocated tables #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suranjan
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
After the connector changes for tablet split in this commit, the connector tests on colocated tables have started failing. The test failures can be seen in
YugabyteDBColocatedTablesTestandYugabyteDBSnapshotTestclasses. This was identified as a regression for colocated tables.Solution
We were relying on the
TabletLocationsPBobject to give us the table ID, however, in case of colocated tables, we only get the colocated parent id which is same for all the colocated tables and is not useful to us. This PR solves the problem by leveraging the table ID from theYBTableobject and using the same to create theHashPartitionThis closes yugabyte/yugabyte-db#20243