Added the workarounds for Synonym export from Oracle in analyze-schema in Details section #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in Details section
priyanshi-yb
requested review from
sanyamsinghal and
amit-yb
and removed request for
sanyamsinghal
sanyamsinghal
approved these changes
Dec 23, 2022
| @@ -672,7 +672,7 @@ func initializeSummaryMap() { | |||
| if objType == "PACKAGE" { | |||
| summaryMap[objType].details["Packages in oracle are exported as schema, please review and edit them(if needed) to match your requirements"] = true | |||
| } else if objType == "SYNONYM" { | |||
| summaryMap[objType].details["Synonyms in oracle are exported as view, please review and edit them(if needed) to match your requirements"] = true | |||
| summaryMap[objType].details["\nSynonyms in oracle are exported as view with full classified name of the object which may have source schema name with object name, which will not be present by default and required to be present in the target database. \nHere are two workarounds, modify the DDLs as per requirement using any of these: \n- Create the schema mentioned in object names and the objects required in that Schema used in those DDLs on the target database.\n- Remove the schema name from all the object names from the DDLs and then it will execute that DDL in the respective target-db-schema passed."] = true | |||
There was a problem hiding this comment.
summaryMap[objType].details["\nSynonyms in oracle are exported as views with fully qualified name of the object which may have source schema name with object name, which will not be present by default and required to be created in the target database. \nHere are two workarounds, modify the DDLs as per requirement using any of these: \n- Create the schema mentioned in object names and the objects required in that Schema used in those DDLs on the target database.\n- Remove the schema name from all the object names from the DDLs and then it will execute that DDL in the provided target-db-schema(default public)."] = true
|
This PR is no more required as it is fixed in this PR #701 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added more details for #673 in analyze-schema in Details section of
SYNONYMobject. Here is the screenshot for that in the analyze report -