Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DumpRunningRpcs could hang if we have timed out calls in queue #1041

Closed
spolitov opened this issue Mar 20, 2019 · 0 comments
Closed

DumpRunningRpcs could hang if we have timed out calls in queue #1041

spolitov opened this issue Mar 20, 2019 · 0 comments
Assignees
@spolitov
Labels
kind/bug This issue is a bug

Comments

@spolitov
Copy link
Contributor

No description provided.

@spolitov spolitov added the kind/bug This issue is a bug label Mar 20, 2019
@spolitov spolitov self-assigned this Mar 20, 2019
yugabyte-ci pushed a commit that referenced this issue Mar 21, 2019
@spolitov
[#1041]: Skip dumping of finished call
3a61698 
Summary:
During network issues send queue could process slowly.
So calls in this queue could timeout w/o being sent.
In case of timeout we invoke call callback immediately,
so corresponding RpcController could be destroyed after that.

If we invoke DumpRunningRpcs while having such calls in queue it could hang.
But it also blocks whole reactor thread, and it cannot perform requests.

Test Plan: ybd --gtest_filter RpcTest.DumpTimedOutCall

Reviewers: amitanand, bogdan

Reviewed By: bogdan

Subscribers: ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D6363
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spolitov spolitov

Labels
kind/bug This issue is a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@spolitov