Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[YSQL] Deprecate unused flags #14727

Closed
andrei-mart opened this issue Oct 28, 2022 · 0 comments
Closed

[YSQL] Deprecate unused flags #14727

andrei-mart opened this issue Oct 28, 2022 · 0 comments
Assignees
@andrei-mart
Labels
area/ysql Yugabyte SQL (YSQL) kind/enhancement This is an enhancement of an existing feature priority/low Low priority status/awaiting-triage Issue awaiting triage

Comments

@andrei-mart
Copy link
Contributor

andrei-mart commented Oct 28, 2022 •
edited by yugabyte-ci
Loading

Jira Link: DB-4071

Description

Since DEPRECATE_FLAG macro is available, apply it to deprecate already unused flags

  • ysql_enable_update_batching
  • ysql_scan_timeout_multiplier
@andrei-mart andrei-mart added kind/enhancement This is an enhancement of an existing feature area/ysql Yugabyte SQL (YSQL) priority/low Low priority status/awaiting-triage Issue awaiting triage labels Oct 28, 2022
@andrei-mart andrei-mart self-assigned this Oct 28, 2022
andrei-mart added a commit that referenced this issue Oct 31, 2022
@andrei-mart
[#14727] YSQL: Deprecate unused flags
b376061 
Summary:
Use the DEPRECATE_FLAG macro to deprecate already unused flags

 - ysql_enable_update_batching
 - ysql_scan_timeout_multiplier

Test Plan:
Jenkins: compile only
No functional changes, only syntax sugar applied

Reviewers: rsami

Reviewed By: rsami

Subscribers: yql

Differential Revision: https://phabricator.dev.yugabyte.com/D20589
@robertsami robertsami mentioned this issue Nov 4, 2022
Open
jayant07-yb pushed a commit to jayant07-yb/yugabyte-db that referenced this issue Dec 7, 2022
@andrei-mart
[yugabyte#14727] YSQL: Deprecate unused flags
cc98d30 
Summary:
Use the DEPRECATE_FLAG macro to deprecate already unused flags

 - ysql_enable_update_batching
 - ysql_scan_timeout_multiplier

Test Plan:
Jenkins: compile only
No functional changes, only syntax sugar applied

Reviewers: rsami

Reviewed By: rsami

Subscribers: yql

Differential Revision: https://phabricator.dev.yugabyte.com/D20589
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrei-mart andrei-mart

Labels
area/ysql Yugabyte SQL (YSQL) kind/enhancement This is an enhancement of an existing feature priority/low Low priority status/awaiting-triage Issue awaiting triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andrei-mart