Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DocDB] Read directly to QLTableRow #16700

Closed
1 task done
spolitov opened this issue Apr 5, 2023 · 0 comments
Closed
1 task done

[DocDB] Read directly to QLTableRow #16700

spolitov opened this issue Apr 5, 2023 · 0 comments
Assignees
@spolitov
Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue

Comments

@spolitov
Copy link
Contributor

spolitov commented Apr 5, 2023 •
edited by jira bot
Loading

Jira Link: DB-6075

Description

Currently DocRowwiseIterator in combination with DocDBTableReader performs read in two steps.
Initially HasNext is invoked, that fetches row to internal representation.
Then NextRow moves internal representation to QLTableRow.

We could replace them with single method FetchNext, that will fetch row to the passed QLTableRow.

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.
@spolitov spolitov added area/docdb YugabyteDB core features status/awaiting-triage Issue awaiting triage labels Apr 5, 2023
@spolitov spolitov self-assigned this Apr 5, 2023
@yugabyte-ci yugabyte-ci added kind/bug This issue is a bug priority/medium Medium priority issue kind/enhancement This is an enhancement of an existing feature and removed kind/bug This issue is a bug status/awaiting-triage Issue awaiting triage labels Apr 5, 2023
spolitov added a commit that referenced this issue Apr 6, 2023
@spolitov
[#16700] DocDB: Read directly to QLTableRow
3ab878d 
Summary:
Currently DocRowwiseIterator in combination with DocDBTableReader performs read in two steps.
Initially HasNext is invoked, that fetches row to internal representation.
Then NextRow moves internal representation to QLTableRow.

This diff replaces them with single method FetchNext, that will fetch row to the passed QLTableRow.

Also updated PgMiniTest.ScanWithPacked to use multiple value columns.
Average execution time in release mode for master (0e0eec3) and updated test: 3.95s
For this diff: 3.69s

Test Plan: Jenkins

Reviewers: kpopali, arybochkin, timur

Reviewed By: timur

Subscribers: rthallam, kpopali, ybase, bogdan

Differential Revision: https://phabricator.dev.yugabyte.com/D24086
premkumr pushed a commit to premkumr/yugabyte-db that referenced this issue Apr 10, 2023
@spolitov @premkumr
[yugabyte#16700] DocDB: Read directly to QLTableRow
46048a5 
Summary:
Currently DocRowwiseIterator in combination with DocDBTableReader performs read in two steps.
Initially HasNext is invoked, that fetches row to internal representation.
Then NextRow moves internal representation to QLTableRow.

This diff replaces them with single method FetchNext, that will fetch row to the passed QLTableRow.

Also updated PgMiniTest.ScanWithPacked to use multiple value columns.
Average execution time in release mode for master (0e0eec3) and updated test: 3.95s
For this diff: 3.69s

Test Plan: Jenkins

Reviewers: kpopali, arybochkin, timur

Reviewed By: timur

Subscribers: rthallam, kpopali, ybase, bogdan

Differential Revision: https://phabricator.dev.yugabyte.com/D24086
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spolitov spolitov

Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@spolitov @rthallamko3 @yugabyte-ci