Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[YSQL] simplify gflags for enabling YSQL #1691

Closed
kmuthukk opened this issue Jul 3, 2019 · 0 comments
Closed

[YSQL] simplify gflags for enabling YSQL #1691

kmuthukk opened this issue Jul 3, 2019 · 0 comments
Assignees
@jaki
Labels
area/ysql Yugabyte SQL (YSQL)

Comments

@kmuthukk
Copy link
Collaborator

kmuthukk commented Jul 3, 2019

• Deprecate yb-tserver gflag --start_pgsql_proxy in favor of a new --enable_ysql gflag.

• Deprecate yb-master gflag --use_initial_sys_catalog_snapshot in favor of a new --enable_ysql gflag.
@kmuthukk kmuthukk added the area/ysql Yugabyte SQL (YSQL) label Jul 3, 2019
jaki pushed a commit that referenced this issue Jul 23, 2019
[YSQL] #1691: Simplify gflags enabling YSQL
e3b02cd 
Summary:
The gflags for enabling YSQL can be named better: `--enable_ysql`.  For
yb-master, introduce this new flag to behave like
`--use_initial_sys_catalog_snapshot`.  For yb-tserver, introduce this new flag
to behave like `--start_pgsql_proxy`.  Set the new flag to false by default for
both master and tserver.

Test Plan:
* Check for existence of postgres processes:
  * `./bin/yb-ctl create`
  * `./bin/yb-ctl create --enable_ysql`
  * `./bin/yb-ctl create --master_flags "enable_ysql=false"
    --tserver_flags "enable_ysql=false"`
  * `./bin/yb-ctl create --master_flags "enable_ysql=true"
    --tserver_flags "enable_ysql=true"`
  * `./bin/yb-ctl create --master_flags
    "enable_ysql=false,use_initial_sys_catalog_snapshot=true"
    --tserver_flags "enable_ysql=false,start_pgsql_proxy=true"`
  * `./bin/yb-ctl create --master_flags
    "enable_ysql=true,use_initial_sys_catalog_snapshot=false"
    --tserver_flags "enable_ysql=true,start_pgsql_proxy=false"`
  * `./bin/yb-ctl create --master_flags
    "enable_ysql=true,use_initial_sys_catalog_snapshot=true"
    --tserver_flags "enable_ysql=true,start_pgsql_proxy=true"`
* Check for non-existence of postgres processes:
  * `./bin/yb-ctl create --disable_ysql`
  * `./bin/yb-ctl create --master_flags
    "use_initial_sys_catalog_snapshot=false" --tserver_flags
    "start_pgsql_proxy=false"`
  * `./bin/yb-ctl create --master_flags
    "enable_ysql=false,use_initial_sys_catalog_snapshot=false"
    --tserver_flags "enable_ysql=false,start_pgsql_proxy=false"`
* `./build/latest/tests-pgwrapper/pg_wrapper-test`
* `cd java && mvn test -Dtest=org.yb.pgsql.TestPgInsert`

Reviewers: bogdan, mihnea, neha

Reviewed By: neha

Subscribers: kannan, neha, yql

Differential Revision: https://phabricator.dev.yugabyte.com/D6870
@jaki jaki closed this as completed Jul 23, 2019
@jaki jaki mentioned this issue Sep 27, 2019
Closed
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaki jaki

Labels
area/ysql Yugabyte SQL (YSQL)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kmuthukk @jaki