Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[YSQL] Partition pruning produces incorrect results during batched NL execution #16991

Closed
1 task done
tanujnay112 opened this issue Apr 24, 2023 · 0 comments
Closed
1 task done

[YSQL] Partition pruning produces incorrect results during batched NL execution #16991

tanujnay112 opened this issue Apr 24, 2023 · 0 comments
Assignees
@tanujnay112
Labels
area/ysql Yugabyte SQL (YSQL) kind/bug This issue is a bug priority/highest Highest priority issue

Comments

@tanujnay112
Copy link
Contributor

tanujnay112 commented Apr 24, 2023 •
edited by jira bot
Loading

Jira Link: DB-6311

Description

It appears that partition pruning operates on an incorrect pruning qual in this test case when yb_bnl_batch_size is turned to 1024 as less rows are produced by this join in this scenario than when BNL is turned off.

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.
@tanujnay112 tanujnay112 added area/ysql Yugabyte SQL (YSQL) status/awaiting-triage Issue awaiting triage labels Apr 24, 2023
@tanujnay112 tanujnay112 self-assigned this Apr 24, 2023
@yugabyte-ci yugabyte-ci added kind/bug This issue is a bug priority/medium Medium priority issue priority/highest Highest priority issue and removed status/awaiting-triage Issue awaiting triage priority/medium Medium priority issue labels Apr 24, 2023
tanujnay112 added a commit that referenced this issue Apr 25, 2023
@tanujnay112
[#16991] YSQL: Update pruning quals when nested loop batching is on
48b3a71 
Summary: The pruning quals for an inner partitioned index scan mistakenly remained unchanged when we change all other inner equality clauses to an IN clause for BNL. This change fixes that.

Test Plan: ./yb_build.sh release --java-test 'org.yb.pgsql.TestPgRegressPartitions'

Reviewers: dsrinivasan, mtakahara

Reviewed By: mtakahara

Subscribers: yql

Differential Revision: https://phabricator.dev.yugabyte.com/D24730
tanujnay112 added a commit that referenced this issue Apr 25, 2023
@tanujnay112
[BACKPORT 2.18][#16991] YSQL: Update pruning quals when nested loop b…
9f170e1 
…atching is on

Summary:
The pruning quals for an inner partitioned index scan mistakenly remained unchanged when we change all other inner equality clauses to an IN clause for BNL. This change fixes that.
Original commit: 48b3a71 / D24730

Test Plan: ./yb_build.sh release --java-test 'org.yb.pgsql.TestPgRegressPartitions'

Reviewers: dsrinivasan, mtakahara

Reviewed By: mtakahara

Subscribers: yql

Differential Revision: https://phabricator.dev.yugabyte.com/D24786
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tanujnay112 tanujnay112

Labels
area/ysql Yugabyte SQL (YSQL) kind/bug This issue is a bug priority/highest Highest priority issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tanujnay112 @yugabyte-ci