Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[YSQL] Explain: Change "Foreign Scan" to "Seq Scan" #2076

Closed
ndeodhar opened this issue Aug 15, 2019 · 0 comments
Closed

[YSQL] Explain: Change "Foreign Scan" to "Seq Scan" #2076

ndeodhar opened this issue Aug 15, 2019 · 0 comments
Assignees
@hulien22
Labels
area/ysql Yugabyte SQL (YSQL)

Comments

@ndeodhar
Copy link
Contributor

In YSQL explain, scan of YB tables gets marked as Foreign Scan because YB is implemented as a postgres FDW. However, this is an implementation detail that should not be exposed. We should change explain to Seq Scan instead of Foreign Scan for YB tables.
@ndeodhar ndeodhar added the area/ysql Yugabyte SQL (YSQL) label Aug 15, 2019
@ndeodhar ndeodhar added this to the v2.0 milestone Aug 15, 2019
@ndeodhar ndeodhar self-assigned this Aug 15, 2019
@ndeodhar ndeodhar assigned iSignal and unassigned ndeodhar Aug 24, 2019
@ndeodhar ndeodhar removed this from the v2.0 milestone May 13, 2020
@ndeodhar ndeodhar assigned hulien22 and unassigned iSignal Jul 2, 2020
hulien22 added a commit that referenced this issue Jul 13, 2020
@hulien22
[YSQL] Replace Foreign Scan with Seq Scan for explain (#2076)
2e70e55 
Summary: Replace "Foreign Scan" with "Seq Scan" when explaining a yb relation

Test Plan:
Edited tests to reflect changes:

```
TestPgCacheConsistency
TestPgPrepareExecute
TestPgPushdown
TestPgUniqueConstraint
```

```
org.yb.pgsql.TestPgRegressAuthorization
org.yb.pgsql.TestPgRegressDml
org.yb.pgsql.TestPgRegressHashIndex
org.yb.pgsql.TestPgRegressIndex
org.yb.pgsql.TestPgRegressPgMisc
org.yb.pgsql.TestPgRegressPgMiscIndependent
org.yb.pgsql.TestPgRegressTypesGeo
org.yb.pgsql.TestPgRegressTypesMisc
org.yb.pgsql.TestPgRegressWindow
```

Reviewers: dmitry, neha, mihnea

Reviewed By: neha

Subscribers: yql

Differential Revision: https://phabricator.dev.yugabyte.com/D8837
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hulien22 hulien22

Labels
area/ysql Yugabyte SQL (YSQL)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@iSignal @ndeodhar @hulien22