Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[YCQL][ASH] Incorrect top_level_node_id in ASH metadata #21945

Closed
1 task done
abhinab-yb opened this issue Apr 12, 2024 · 0 comments
Closed
1 task done

[YCQL][ASH] Incorrect top_level_node_id in ASH metadata #21945

abhinab-yb opened this issue Apr 12, 2024 · 0 comments
Assignees
@amitanandaiyer
Labels
area/ycql Yugabyte CQL (YCQL) kind/bug This issue is a bug priority/medium Medium priority issue

Comments

@abhinab-yb
Copy link
Contributor

abhinab-yb commented Apr 12, 2024 •
edited
Loading

Jira Link: DB-10862

Description

In a rf-3 cluster with tserver uuids as 05b1b49c8d6349a8b5d2158d247b2726 , a8b775a326ba454dac7540ff42436022 and db546cfcdc474bc58a1023b1442a3078. The yql_endpoint_tserver_uuid for YCQL samples are not present in the cluster.

yugabyte=# select distinct(top_level_node_id), wait_event_component from yb_active_session_history;
      top_level_node_id       | wait_event_component 
--------------------------------------+----------------------
 05b1b49c-8d63-49a8-b5d2-158d247b2726 | TServer
 22604342-ff40-75ac-4d45-ba26a375b7a8 | YCQL
 a8b775a3-26ba-454d-ac75-40ff42436022 | TServer
 00000000-0000-0000-0000-000000000000 | TServer
 22604342-ff40-75ac-4d45-ba26a375b7a8 | TServer
 db546cfc-dc47-4bc5-8a10-23b1442a3078 | TServer
 00000000-0000-0000-0000-000000000000 | YCQL
 a8b775a3-26ba-454d-ac75-40ff42436022 | YSQL
(8 rows)

Issue Type

kind/bug

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.
@abhinab-yb abhinab-yb added area/ycql Yugabyte CQL (YCQL) status/awaiting-triage Issue awaiting triage labels Apr 12, 2024
@yugabyte-ci yugabyte-ci added kind/bug This issue is a bug priority/medium Medium priority issue labels Apr 12, 2024
@abhinab-yb abhinab-yb changed the title [YCQL][ASH] Incorect top_level_node_id [YCQL][ASH] Incorect top_level_node_id in ASH metadata Apr 12, 2024
@yugabyte-ci yugabyte-ci removed the status/awaiting-triage Issue awaiting triage label Apr 22, 2024
@abhinab-yb abhinab-yb changed the title [YCQL][ASH] Incorect top_level_node_id in ASH metadata [YCQL][ASH] Incorrect top_level_node_id in ASH metadata Apr 23, 2024
amitanandaiyer added a commit that referenced this issue Apr 25, 2024
@amitanandaiyer
[#21945] ASH: Fix incorrect top_level_node_id in ASH metadata
0f7be92 
Summary:
Currently we use Uuid::FromHexString to convert the node/instance_id to uuid.
However, this function expects the string to be encoded using LittleEndian.

ToBytes/FromBytes uses BigEndian order, thus we were seeing uuids reversed
in ash.

To fix this, we avoid using FromHexString and implement/use FromHexStringBigEndian.
This is similar to Uuid::FromString, except for also accepting string without dashes.
Jira: DB-10862

Test Plan: yb_build.sh --cxx-test wait_states-itest

Reviewers: asaha, hsunder

Reviewed By: asaha

Subscribers: ybase, yql

Differential Revision: https://phorge.dev.yugabyte.com/D34332
amitanandaiyer added a commit that referenced this issue Apr 25, 2024
@amitanandaiyer
[BACKPORT 2024.1][#21945] ASH: Fix incorrect top_level_node_id in ASH…
d068091 
… metadata

Summary:
Original commit: 0f7be92 / D34332
Currently we use Uuid::FromHexString to convert the node/instance_id to uuid.
However, this function expects the string to be encoded using LittleEndian.

ToBytes/FromBytes uses BigEndian order, thus we were seeing uuids reversed
in ash.

To fix this, we avoid using FromHexString and implement/use FromHexStringBigEndian.
This is similar to Uuid::FromString, except for also accepting string without dashes.
Jira: DB-10862

Test Plan: yb_build.sh --cxx-test wait_states-itest

Reviewers: asaha, hsunder

Reviewed By: asaha

Subscribers: yql, ybase

Tags: #jenkins-ready

Differential Revision: https://phorge.dev.yugabyte.com/D34519
svarnau pushed a commit that referenced this issue May 25, 2024
@amitanandaiyer
[#21945] ASH: Fix incorrect top_level_node_id in ASH metadata
7e87e51 
Summary:
Currently we use Uuid::FromHexString to convert the node/instance_id to uuid.
However, this function expects the string to be encoded using LittleEndian.

ToBytes/FromBytes uses BigEndian order, thus we were seeing uuids reversed
in ash.

To fix this, we avoid using FromHexString and implement/use FromHexStringBigEndian.
This is similar to Uuid::FromString, except for also accepting string without dashes.
Jira: DB-10862

Test Plan: yb_build.sh --cxx-test wait_states-itest

Reviewers: asaha, hsunder

Reviewed By: asaha

Subscribers: ybase, yql

Differential Revision: https://phorge.dev.yugabyte.com/D34332
ZhenYongFan pushed a commit to ZhenYongFan/yugabyte-db that referenced this issue Jun 15, 2024
@amitanandaiyer
[BACKPORT 2024.1][yugabyte#21945] ASH: Fix incorrect top_level_node_i…
48c47eb 
…d in ASH metadata

Summary:
Original commit: 0f7be92 / D34332
Currently we use Uuid::FromHexString to convert the node/instance_id to uuid.
However, this function expects the string to be encoded using LittleEndian.

ToBytes/FromBytes uses BigEndian order, thus we were seeing uuids reversed
in ash.

To fix this, we avoid using FromHexString and implement/use FromHexStringBigEndian.
This is similar to Uuid::FromString, except for also accepting string without dashes.
Jira: DB-10862

Test Plan: yb_build.sh --cxx-test wait_states-itest

Reviewers: asaha, hsunder

Reviewed By: asaha

Subscribers: yql, ybase

Tags: #jenkins-ready

Differential Revision: https://phorge.dev.yugabyte.com/D34519
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amitanandaiyer amitanandaiyer

Labels
area/ycql Yugabyte CQL (YCQL) kind/bug This issue is a bug priority/medium Medium priority issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yugabyte-ci @amitanandaiyer @abhinab-yb