Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DocDB] Ability to show rpc bind addresses in master leader UI when broadcast/http addresses are different #21959

Closed
1 task done
iSignal opened this issue Apr 12, 2024 · 0 comments
Assignees
Labels
area/docdb YugabyteDB core features kind/bug This issue is a bug priority/medium Medium priority issue

Comments

@iSignal
Copy link
Contributor

iSignal commented Apr 12, 2024

Jira Link: DB-10875

Description

In some cases, the local bind address could be more useful than the broadcast/http address. One such case is in k8s when the broadcast address is set to a node ip but the rpc bind address with the pod DNS is more useful.

Issue Type

kind/bug

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.
@iSignal iSignal added area/docdb YugabyteDB core features status/awaiting-triage Issue awaiting triage labels Apr 12, 2024
@yugabyte-ci yugabyte-ci added kind/bug This issue is a bug priority/medium Medium priority issue labels Apr 12, 2024
@yugabyte-ci yugabyte-ci removed the status/awaiting-triage Issue awaiting triage label Apr 12, 2024
iSignal added a commit that referenced this issue Apr 13, 2024
Summary: Original diff: https://phorge.dev.yugabyte.com/D33726

Test Plan: Start tserver with rpc bind and http addresses set differently and verify that the display shows this.

Reviewers: hsunder

Reviewed By: hsunder

Subscribers: bogdan, ybase, esheng

Tags: #jenkins-ready

Differential Revision: https://phorge.dev.yugabyte.com/D34010
iSignal added a commit that referenced this issue Apr 18, 2024
Summary: Original diff: https://phorge.dev.yugabyte.com/D33726

Test Plan:
Start tserver with rpc bind and http addresses set differently and verify that the display shows this.

Reviewers: hsunder

Reviewed By: hsunder

Subscribers: bogdan, ybase, esheng

Tags: #jenkins-ready

Differential Revision: https://phorge.dev.yugabyte.com/D34011
iSignal added a commit that referenced this issue Apr 18, 2024
Test Plan:
Start tserver with rpc bind and http addresses set differently and verify that the display shows this. Tested with --rpc_bind_addresses set to 0.0.0.0 and verified that the hostname shows up instead (this seems to depend on whether ybdb can discover a local hostname)

{F166067}

Reviewers: hsunder

Reviewed By: hsunder

Subscribers: hsunder, esheng, ybase, bogdan

Differential Revision: https://phorge.dev.yugabyte.com/D33726
svarnau pushed a commit that referenced this issue May 25, 2024
Test Plan:
Start tserver with rpc bind and http addresses set differently and verify that the display shows this. Tested with --rpc_bind_addresses set to 0.0.0.0 and verified that the hostname shows up instead (this seems to depend on whether ybdb can discover a local hostname)

{F166067}

Reviewers: hsunder

Reviewed By: hsunder

Subscribers: hsunder, esheng, ybase, bogdan

Differential Revision: https://phorge.dev.yugabyte.com/D33726
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docdb YugabyteDB core features kind/bug This issue is a bug priority/medium Medium priority issue
Projects
None yet
Development

No branches or pull requests

2 participants