[CDCSDK] Suppress notice messages when yb_read_time is being set by the walsender #22379
Assignees
Labels
2024.1_blocker
2024.1.0_blocker
area/cdcsdk
CDC SDK
jira-originated
kind/enhancement
This is an enhancement of an existing feature
priority/medium
Medium priority issue
Comments
yugabyte-ci
added
area/cdcsdk
yugabyte-ci
added
2024.1_blocker
2024.1.0_blocker
and removed
status/awaiting-triage
Sumukh-Phalgaonkar
added a commit
that referenced
this issue
May 14, 2024
…m walsender Summary: Currently whenever yb_read_time is set, a NOTICE message is issued. However, the walsender sets the yb_read_time for DDLs and publication refresh processing. This can lead to unnecessary clutter of NOTICE messages, hence we want to suppress the logging of NOTICE message when yb_read_time is being set from the walsender. This diff introduces the changes required for the same. The decision to log the NOTICE message is taken on the basis of `am_walsender` boolean, which is true for a walsender process and false otherwise. Jira: DB-11279 Test Plan: Existing tests Reviewers: stiwary, asrinivasan Reviewed By: stiwary Subscribers: yql, ycdcxcluster Tags: #jenkins-ready Differential Revision: https://phorge.dev.yugabyte.com/D35030
Sumukh-Phalgaonkar
added a commit
that referenced
this issue
May 15, 2024
…ng yb_read_time from walsender Summary: Original commit: 12b6c74 / D35030 Currently whenever yb_read_time is set, a NOTICE message is issued. However, the walsender sets the yb_read_time for DDLs and publication refresh processing. This can lead to unnecessary clutter of NOTICE messages, hence we want to suppress the logging of NOTICE message when yb_read_time is being set from the walsender. This diff introduces the changes required for the same. The decision to log the NOTICE message is taken on the basis of `am_walsender` boolean, which is true for a walsender process and false otherwise. #####Backport Description No merge conflicts were encountered. Jira: DB-11279 Test Plan: Existing tests Reviewers: stiwary, asrinivasan Reviewed By: stiwary Subscribers: yql, ycdcxcluster Tags: #jenkins-ready Differential Revision: https://phorge.dev.yugabyte.com/D35054
Sumukh-Phalgaonkar
added a commit
that referenced
this issue
May 15, 2024
… yb_read_time from walsender Summary: Original commit: 12b6c74 / D35030 Currently whenever yb_read_time is set, a NOTICE message is issued. However, the walsender sets the yb_read_time for DDLs and publication refresh processing. This can lead to unnecessary clutter of NOTICE messages, hence we want to suppress the logging of NOTICE message when yb_read_time is being set from the walsender. This diff introduces the changes required for the same. The decision to log the NOTICE message is taken on the basis of `am_walsender` boolean, which is true for a walsender process and false otherwise. #####Backport Description No merge conflicts were encountered. Jira: DB-11279 Test Plan: Existing tests Reviewers: stiwary, asrinivasan Reviewed By: stiwary Subscribers: ycdcxcluster, yql Tags: #jenkins-ready Differential Revision: https://phorge.dev.yugabyte.com/D35053
svarnau
pushed a commit
that referenced
this issue
May 25, 2024
…m walsender Summary: Currently whenever yb_read_time is set, a NOTICE message is issued. However, the walsender sets the yb_read_time for DDLs and publication refresh processing. This can lead to unnecessary clutter of NOTICE messages, hence we want to suppress the logging of NOTICE message when yb_read_time is being set from the walsender. This diff introduces the changes required for the same. The decision to log the NOTICE message is taken on the basis of `am_walsender` boolean, which is true for a walsender process and false otherwise. Jira: DB-11279 Test Plan: Existing tests Reviewers: stiwary, asrinivasan Reviewed By: stiwary Subscribers: yql, ycdcxcluster Tags: #jenkins-ready Differential Revision: https://phorge.dev.yugabyte.com/D35030
svarnau
pushed a commit
that referenced
this issue
May 29, 2024
… yb_read_time from walsender Summary: Original commit: 12b6c74 / D35030 Currently whenever yb_read_time is set, a NOTICE message is issued. However, the walsender sets the yb_read_time for DDLs and publication refresh processing. This can lead to unnecessary clutter of NOTICE messages, hence we want to suppress the logging of NOTICE message when yb_read_time is being set from the walsender. This diff introduces the changes required for the same. The decision to log the NOTICE message is taken on the basis of `am_walsender` boolean, which is true for a walsender process and false otherwise. #####Backport Description No merge conflicts were encountered. Jira: DB-11279 Test Plan: Existing tests Reviewers: stiwary, asrinivasan Reviewed By: stiwary Subscribers: ycdcxcluster, yql Tags: #jenkins-ready Differential Revision: https://phorge.dev.yugabyte.com/D35053
ZhenYongFan
pushed a commit
to ZhenYongFan/yugabyte-db
that referenced
this issue
Jun 15, 2024
…le setting yb_read_time from walsender Summary: Original commit: 12b6c74 / D35030 Currently whenever yb_read_time is set, a NOTICE message is issued. However, the walsender sets the yb_read_time for DDLs and publication refresh processing. This can lead to unnecessary clutter of NOTICE messages, hence we want to suppress the logging of NOTICE message when yb_read_time is being set from the walsender. This diff introduces the changes required for the same. The decision to log the NOTICE message is taken on the basis of `am_walsender` boolean, which is true for a walsender process and false otherwise. #####Backport Description No merge conflicts were encountered. Jira: DB-11279 Test Plan: Existing tests Reviewers: stiwary, asrinivasan Reviewed By: stiwary Subscribers: yql, ycdcxcluster Tags: #jenkins-ready Differential Revision: https://phorge.dev.yugabyte.com/D35054
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Jira Link: DB-11279
The text was updated successfully, but these errors were encountered: