Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DocDB] Hidden state in master tables UI is not easy to notice #22521

Closed
1 task done
hari90 opened this issue May 24, 2024 · 1 comment
Closed
1 task done

[DocDB] Hidden state in master tables UI is not easy to notice #22521

hari90 opened this issue May 24, 2024 · 1 comment
Assignees
Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature kind/improve-ux Issues relating to improving user experience. priority/medium Medium priority issue

Comments

@hari90
Copy link
Contributor

hari90 commented May 24, 2024

Jira Link: DB-11448

Description

Currently we have one column that tells us if a table is HIDDEN. It is at the far right and not easy to notice.
Either move the tiny hidden column next to the state or show the state as RUNNING(HIDDEN)

image

Issue Type

kind/improve-ux

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.
@hari90 hari90 added area/docdb YugabyteDB core features status/awaiting-triage Issue awaiting triage labels May 24, 2024
@hari90 hari90 self-assigned this May 24, 2024
@yugabyte-ci yugabyte-ci added kind/improve-ux Issues relating to improving user experience. priority/medium Medium priority issue kind/enhancement This is an enhancement of an existing feature labels May 24, 2024
@hari90
Copy link
Contributor Author

hari90 commented May 30, 2024

image

@yugabyte-ci yugabyte-ci removed the status/awaiting-triage Issue awaiting triage label Jun 5, 2024
@hari90 hari90 closed this as completed in 3a1e4f2 Jun 13, 2024
hari90 added a commit that referenced this issue Jun 13, 2024
…Tables UI more prominently

Summary:
Original commit: 3a1e4f2 / D35465
Currently the hidden state is shown in the UI as a column at the far right of the table. This is not very visible and can be easily missed. This diff moves the hidden info to the  state column to make it more visible.
Also using the new table UI helper class to make the code more consistent.

- Also moved the macros to a Class to make it simpler to use. The macro required the developer to include `HTML_END_TABLE` and `HTML_ADD_SORT_AND_FILTER_TABLE_SCRIPT`, which the classes take care of automatically, make it easier to use. And moved this class to the server folder where webserver files exist instead of the common folder.

Fixes #22521
Jira: DB-11448

Test Plan:
Manually validated the changes in the UI

Previous page:

{image uri=https://github.com/yugabyte/yugabyte-db/assets/12418230/56703f0a-e15d-4c99-81bc-5ba05a838207, width=1000px, alt=picture of a moose, href=google.com}

New page:
{image uri=https://github.com/yugabyte/yugabyte-db/assets/12418230/3d8f8604-29f2-48f5-9808-6a8fabee1f40, width=1200px, alt=picture of a moose, href=google.com}

Reviewers: asrivastava

Reviewed By: asrivastava

Subscribers: esheng, ybase

Tags: #jenkins-ready

Differential Revision: https://phorge.dev.yugabyte.com/D35828
karthik-ramanathan-3006 pushed a commit to karthik-ramanathan-3006/yugabyte-db that referenced this issue Jun 24, 2024
… more prominently

Summary:
Currently the hidden state is shown in the UI as a column at the far right of the table. This is not very visible and can be easily missed. This diff moves the hidden info to the  state column to make it more visible.
Also using the new table UI helper class to make the code more consistent.

- Also moved the macros to a Class to make it simpler to use. The macro required the developer to include `HTML_END_TABLE` and `HTML_ADD_SORT_AND_FILTER_TABLE_SCRIPT`, which the classes take care of automatically, make it easier to use. And moved this class to the server folder where webserver files exist instead of the common folder.

Fixes yugabyte#22521
Jira: DB-11448

Test Plan:
Manually validated the changes in the UI

Previous page:

{image uri=https://github.com/yugabyte/yugabyte-db/assets/12418230/56703f0a-e15d-4c99-81bc-5ba05a838207, width=1000px, alt=picture of a moose, href=google.com}

New page:
{image uri=https://github.com/yugabyte/yugabyte-db/assets/12418230/3d8f8604-29f2-48f5-9808-6a8fabee1f40, width=1200px, alt=picture of a moose, href=google.com}

Reviewers: asrivastava

Reviewed By: asrivastava

Subscribers: ybase, esheng

Differential Revision: https://phorge.dev.yugabyte.com/D35465
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature kind/improve-ux Issues relating to improving user experience. priority/medium Medium priority issue
Projects
None yet
Development

No branches or pull requests

2 participants