Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Num Tablets with Read Replicas #2630

Closed
rahuldesirazu opened this issue Oct 16, 2019 · 0 comments
Closed

Fix Num Tablets with Read Replicas #2630

rahuldesirazu opened this issue Oct 16, 2019 · 0 comments
Assignees
@rahuldesirazu
Labels
area/docdb YugabyteDB core features kind/bug This issue is a bug

Comments

@rahuldesirazu
Copy link
Contributor

When creating a table, we want to calculate the number of tablets by the number of tservers in the primary cluster. When we have both read replica and primary nodes, we currently use all the tservers in the calculation, instead of just primary.
@rahuldesirazu rahuldesirazu added kind/bug This issue is a bug area/docdb YugabyteDB core features labels Oct 16, 2019
rahuldesirazu added a commit that referenced this issue Oct 17, 2019
@rahuldesirazu
[#2630] Fix num tablets per table
942eaff 
Summary: When creating a table, we want to calculate the number of tablets by the number of tservers in the primary cluster. When we have both read replica and primary nodes, we currently use all the tservers in the calculation, instead of just primary. This happens when we have no placement uuid for the primary cluster, as we automatically consider a tserver primary if the passed in placement uuid is not set. Fix is a one-liner to just check equality between tserver and config placement uuid.

Test Plan: Manual testing with yb-admin: created a table and made sure it had correct number of tablets.

Reviewers: nicolas, bogdan, hector

Reviewed By: hector

Subscribers: kannan, ybase, bogdan

Differential Revision: https://phabricator.dev.yugabyte.com/D7408
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rahuldesirazu rahuldesirazu

Labels
area/docdb YugabyteDB core features kind/bug This issue is a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rahuldesirazu