Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docdb] master UI make hash_split more readable #4811

Closed
jaki opened this issue Jun 17, 2020 · 5 comments · Fixed by #6223
Closed

[docdb] master UI make hash_split more readable #4811

jaki opened this issue Jun 17, 2020 · 5 comments · Fixed by #6223
Labels
area/ui All issues relating to UI/UX good first issue This is a good issue to start contributing! help wanted We welcome your contributions for this issue! kind/improve-ux Issues relating to improving user experience.

Comments

@jaki
Copy link
Contributor

jaki commented Jun 17, 2020

The master UI table page shows tablets and their partitions. If the table is default hash partitioned to two tablets, the partitions show as hash_split: [<start>, 32767) and hash_split: [32767, <end>). It's confusing at first glance, but 32767 maps to 0x7fff, which is the middle hash code between 0x0000 and 0xffff. It would be more understandable if we used hex notation or the dockey string representation that is used for range partitioned tables (e.g. range: [(<start>, DocKey([], [3])))). Do one of those changes to make this more readable.

@jaki jaki added kind/improve-ux Issues relating to improving user experience. area/ui All issues relating to UI/UX labels Jun 17, 2020
@bmatican bmatican removed their assignment Jul 6, 2020
@bmatican bmatican added good first issue This is a good issue to start contributing! help wanted We welcome your contributions for this issue! labels Jul 6, 2020
@adzimzf
Copy link
Contributor

adzimzf commented Oct 13, 2020

Hi,
I interest to work on this, but since this is my first time, maybe it'll bit longer

@bmatican
Copy link
Contributor

@adzimzf that would be perfectly fine! One suggestion, especially as this would be your first time contribution, might be useful to join our slack (http://yugabyte-db.slack.com/), as we could provide some more real time assistance in our #contributors channel.

@adzimzf
Copy link
Contributor

adzimzf commented Oct 16, 2020

Thank you @bmatican,
I'll try to read as much as I can first, if stuck I'll ask on the slack

@adzimzf
Copy link
Contributor

adzimzf commented Oct 30, 2020

Hi @bmatican I've created a PR for this issue,
please feel free to correct the PR, and sorry if there's a lot of mistakes 🙏

@jaki
Copy link
Contributor Author

jaki commented Nov 2, 2020

(From #6223) To clarify, this issue does not need to concern itself with YSQL tables which currently show no bounds for hash partitioning. I can create a separate issue for that if none exists.

@jaki jaki closed this as completed in #6223 Nov 6, 2020
jaki pushed a commit that referenced this issue Nov 6, 2020
Summary:
Master UI make hash_split more readable

Fix: #4811
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui All issues relating to UI/UX good first issue This is a good issue to start contributing! help wanted We welcome your contributions for this issue! kind/improve-ux Issues relating to improving user experience.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants