Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete unused/failed checkpoints created for remote bootstrap #498

Closed
ttyusupov opened this issue Oct 9, 2018 · 1 comment
Closed

Delete unused/failed checkpoints created for remote bootstrap #498

ttyusupov opened this issue Oct 9, 2018 · 1 comment
Assignees
@hectorgcr
Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature

Comments

@ttyusupov
Copy link
Contributor

ttyusupov commented Oct 9, 2018 •
edited
Loading

Currently, checkpoints might be not deleted after remote bootstrap has failed.
@ttyusupov ttyusupov added the kind/bug This issue is a bug label Oct 9, 2018
@ttyusupov ttyusupov added kind/enhancement This is an enhancement of an existing feature and removed kind/bug This issue is a bug labels Oct 9, 2018
@hectorgcr
Copy link
Contributor

@ttyusupov I'm assuming you meant that we leave directories for tservers that crashed during the remote bootstrap. We do have code to delete the directory if the remote bootstrap finishes, regardless whether the remote bootstrap failed or succeeded. It is in RemoteBootstrapSession::~RemoteBootstrapSession()

@bmatican bmatican added the area/docdb YugabyteDB core features label Jul 15, 2019
yugabyte-ci pushed a commit that referenced this issue Jul 17, 2019
@spolitov
[#498] Cleanup checkpoints on startup
2df6ee1 
Summary:
Source tablet server could crash during remote bootstrap.
So checkpoint directory would not be deleted.

Added mechanism to cleanup checkpoint directories on startup.

Test Plan: ybd debug --cxx-test remote_bootstrap-itest --gtest_filter RemoteBootstrapITest.*

Reviewers: bogdan, oleg, hector

Reviewed By: hector

Subscribers: kannan, oleg, ybase, bogdan

Differential Revision: https://phabricator.dev.yugabyte.com/D6895
@bmatican bmatican mentioned this issue Jul 17, 2019
Closed
@bmatican bmatican closed this as completed Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hectorgcr hectorgcr

Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bmatican @ttyusupov @hectorgcr