YBSession API cleanup #8201
Assignees
Labels
kind/enhancement
This is an enhancement of an existing feature
Comments
ttyusupov
added
the
kind/enhancement
ttyusupov
added a commit
that referenced
this issue
Apr 28, 2021
Summary: Behavior of `YBSession::GetAndClearPendingErrors` is unpredicable before calling `YBSession::Flush*` and it is error-prone to use this function before session flush. Following changes have been made to clean up `YBSession` API and made it less error-prone: - Added `FlushStatus` structure that contains the general status of session flush action and per-operation errors if occurred. - Reworked `YBSession` to pass `FlushStatus` to flush callback instead of `Status`. - Removed `YBSession::GetAndClearPendingErrors` - Removed unused functions/parameters from `YBSession` interface. - Functions that are only used from test code and shouldn't be used in production code have been renamed to `TEST_*`. - Updated the code using `YBSession` according to API changes. Proposed review order: - session.h/session.cc - yql/* - table_handle.* - tablet.* - the rest (test classes) Test Plan: - Jenkins Reviewers: mbautin, sergei Reviewed By: sergei Subscribers: bogdan Differential Revision: https://phabricator.dev.yugabyte.com/D11377
spolitov
added a commit
that referenced
this issue
Apr 29, 2021
Summary: After landing the following non conflicting diffs master builds got broken: 7e12e38/D11377 300a1eb/D11366 This diff fixes the build. Test Plan: Jenkins Reviewers: dmitry, timur Reviewed By: timur Subscribers: ybase Differential Revision: https://phabricator.dev.yugabyte.com/D11413
YintongMa
pushed a commit
to YintongMa/yugabyte-db
that referenced
this issue
May 26, 2021
Summary: Behavior of `YBSession::GetAndClearPendingErrors` is unpredicable before calling `YBSession::Flush*` and it is error-prone to use this function before session flush. Following changes have been made to clean up `YBSession` API and made it less error-prone: - Added `FlushStatus` structure that contains the general status of session flush action and per-operation errors if occurred. - Reworked `YBSession` to pass `FlushStatus` to flush callback instead of `Status`. - Removed `YBSession::GetAndClearPendingErrors` - Removed unused functions/parameters from `YBSession` interface. - Functions that are only used from test code and shouldn't be used in production code have been renamed to `TEST_*`. - Updated the code using `YBSession` according to API changes. Proposed review order: - session.h/session.cc - yql/* - table_handle.* - tablet.* - the rest (test classes) Test Plan: - Jenkins Reviewers: mbautin, sergei Reviewed By: sergei Subscribers: bogdan Differential Revision: https://phabricator.dev.yugabyte.com/D11377
YintongMa
pushed a commit
to YintongMa/yugabyte-db
that referenced
this issue
May 26, 2021
Summary: After landing the following non conflicting diffs master builds got broken: 7e12e38/D11377 300a1eb/D11366 This diff fixes the build. Test Plan: Jenkins Reviewers: dmitry, timur Reviewed By: timur Subscribers: ybase Differential Revision: https://phabricator.dev.yugabyte.com/D11413
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The behavior of
YBSession::GetAndClearPendingErrorsis unpredictable when calling it before YBSession::Flush* and it is error-prone to use this function before session flush.The goal is to update
YBSessionAPI to make it more clear and less error-prone.The text was updated successfully, but these errors were encountered: