Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use correct kv_store_id for post-split tablets #9940

Closed
ttyusupov opened this issue Sep 7, 2021 · 0 comments
Closed

Use correct kv_store_id for post-split tablets #9940

ttyusupov opened this issue Sep 7, 2021 · 0 comments
Assignees
@ttyusupov
Labels
area/docdb YugabyteDB core features kind/bug This issue is a bug

Comments

@ttyusupov
Copy link
Contributor

No description provided.

@ttyusupov ttyusupov added kind/bug This issue is a bug area/docdb YugabyteDB core features labels Sep 7, 2021
@ttyusupov ttyusupov self-assigned this Sep 7, 2021
ttyusupov added a commit that referenced this issue Sep 8, 2021
@ttyusupov
[#9940] docdb: use correct kv_store_id for post-split tablets
5a6e364 
Summary:
The child tablet's kv_store_id was still set to kv_store_id of the parent tablet after the split. Fixed this and updated the test to verify kv_store_id correctness after the split.
kv_store_id is not used in production code so far because #681 has been postponed. And tablet splitting is not enabled by default yet.
So, there should be no harm from that bug so far.

Test Plan: `TabletSplitTest.SplitTablet`

Reviewers: bogdan, rsami

Reviewed By: rsami

Subscribers: ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D12913
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ttyusupov ttyusupov

Labels
area/docdb YugabyteDB core features kind/bug This issue is a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ttyusupov