Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#8620] [Platform] [Backport-2.6] Reset the values on cancel. #8626

Merged

Conversation

nishantSharma459
Copy link
Contributor

Description:
Backup -> Edit configuration. I edited something in the AWS key but I clicked cancel, though the value is not saved, the values I edited are still showing up. Once I reload the page, the edited values are gone and original (saved) values are shown, which is correct. It's good to reload the original values if cancel clicked rather than showing the edited values.

Test Plan:

  1. Click on config from the side nav.
  2. Go to Backup-> AWS.
  3. Create a new Backup config.
  4. Hit the Edit configuration button.
  5. Change some values and hit the Cancel button.

Check if it's restoring the original values or not.

@lgtm-com
Copy link

lgtm-com bot commented May 26, 2021

This pull request introduces 3 alerts when merging 4ab0e06 into 87d1d5c - view on LGTM.com

new alerts:

  • 2 for Potentially inconsistent state update
  • 1 for Unused or undefined state property

@lgtm-com
Copy link

lgtm-com bot commented May 26, 2021

This pull request introduces 4 alerts when merging 6383c5d into 8d85d99 - view on LGTM.com

new alerts:

  • 3 for Potentially inconsistent state update
  • 1 for Unused or undefined state property

Copy link
Collaborator

@sshev sshev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Platform
  
Closed
Development

Successfully merging this pull request may close these issues.

[Platform] Clicking cancel on 'Edit configuration' on backup shows the edited values
2 participants