Added beat listener to call agent.ping() for state #11
Conversation
agent.ping() updates the state of the agent
to show that the agent is alive internally.
This is the first step to getting a proper
agentDisconnect event.
|
Adding tests shortly, just getting this started so I can add to it. |
| Agent.prototype.ping = function () { | ||
| this.connected = true; | ||
| this.seen = new Date(); | ||
| this.emit('beat'); |
There was a problem hiding this comment.
Nitpick: Double quotes in this project. Otherwise, this is looking good so far!
The `onbeforeunload` event will trigger a dynamic image that loads a url like: `/ping/unload/AGENT_ID` This will allow the server to set the agent to a disconnected state so it won't be processed any longer. This is safer than a socket connection or an XHR request since it's a simple ping with a dead image.
|
@reid This latest addition handles a browser leaving the page with the beforeunload event. I need to simulate a crash to see if that catches it, but it should catch windows closing or navigating away (when not by navigated by yeti). |
| @@ -280,6 +280,14 @@ Hub.prototype._onRunConnection = function (socket) { | |||
| socket.emit("ready", id, function () { | |||
| self.debug("Recv"); | |||
| }); | |||
|
|
|||
| socket.on("beat", function () { | |||
There was a problem hiding this comment.
The correct place to put this listener is inside Agent#setupEvents in lib/hub/agent.js. When you listen against that method's self.socketEmitter, you're listening on an EventYoshi that has only the current socket EventEmitter attached. (The socket is attached to the socketEmitter by AgentManager#connectAgent.) This prevents leaks of sockets as agents connect and disconnect frequently, and it prevents breakage as I merge this into the sockjs branch.
I'm taking care of it, so just FYI.
|
|
||
| //Keeps it safe from outside execution | ||
| if (agent) { | ||
| switch (action) { |
There was a problem hiding this comment.
FYI: make lint complains about this switch, so I fixed this today.
The frontend stuff in lib/hub/view/public currently fails the linter pretty hard, but I try to keep the Node.js side of things clean. I hope to resolve the linter errors in the FE JS soon.
There was a problem hiding this comment.
I checked that into my agentDisconnect branch a little while ago.
Linter fixup for pull request yui#11.
Move rendering of test results away from lib/cli.js into a FeedbackLineReporter in lib/reporter/feedback-line.js. The idea is to create a other reporters, e.g. JUnitReporter, with the same interface.
- Introduce JUnitReporter. - Introduce `--junit` and `--output junit` CLI options.
agent.ping() updates the state of the agent
to show that the agent is alive internally.
This is the first step to getting a proper
agentDisconnect event.