Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slider from markup functional test fails for FF #1431

Closed
jconniff opened this issue Nov 22, 2013 · 2 comments
Closed

Slider from markup functional test fails for FF #1431

jconniff opened this issue Nov 22, 2013 · 2 comments

Comments

@jconniff
Copy link
Contributor

The test 'volume button should open and close slider'
relies on
slider.getComputedStyle('display')
Firefox has a know bug where it returns 'inline' when you'd expect 'none'.
This test needs to be rewritten to work around this.
The example works fine when the volume button is manually clicked.
It's not a release blocker
@ghost ghost assigned jconniff Nov 22, 2013
@clarle
Copy link
Collaborator

clarle commented Nov 25, 2013

@ezequiel It looks like the test you mentioned before wasn't the only failure with Firefox and getComputedStyle.

@jconniff Can you help give us some references on this bug? I haven't heard of it yet, so would love to have more information on it.

jconniff added a commit to jconniff/yui3 that referenced this issue Jan 16, 2014
@jconniff
fixes yui#1431 Slider from markup functional test fails for FF
fb9a61e
@jconniff jconniff reopened this Jan 17, 2014
@jconniff
Copy link
Contributor Author

@ezequiel @clarle
See this Gist for an explanation. This could explain a lot of FF + getComputedStyle issues.
https://gist.github.com/jconniff/edf8f728589e4b458d16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jconniff @clarle