Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A user is unable to use the keyboard to access an ac-list if plugged with tokenInput #1913

Closed
marclundgren opened this issue Jul 21, 2014 · 0 comments

Comments

@marclundgren
Copy link
Contributor

Hey @rgrove,

I noticed that between 3.4.1 and 3.5.0, this behavior started appearing for nodes plug'd with tokenInput and AC.

Here is a jsfiddle that shows the issue at 3.17.0
Here is a jsfiddle with the same code at 3.4.0

I've isolated this issued to Move autocomplete-list keyboard handlers into a standalone autocomplete-list-keys module.

Since ListKeys is binding keys before bindUI,AutoCompleteList has not declared tokenInput the host of _inputNode.

By changing ListKeys's bindKeys call to:

Y.after(this._bindKeys, this, 'bindUI');

...we avoid needing to detach (and reattach) _keyEvents, or the need to call bindUIACBase at all :)

Pull request: #1915

EDIT: title, because words are hard.
EDIT2: reworded paragraph.
EDIT3: pull request
EDIT4: sent to dev-master

@marclundgren marclundgren changed the title A user is unable to use the keyboard to access an ac-list with the keyboard if plugged with tokenInput A user is unable to use the keyboard to access an ac-list if plugged with tokenInput Jul 21, 2014
marclundgren pushed a commit to marclundgren/yui3 that referenced this issue Jul 21, 2014
@ybldr ybldr closed this as completed in 3ccb824 Jul 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant