added options to sort() and _sort() #1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Isn't sorting always ascending or descending? It seems like one would only want to modify the comparator in some cases, but the _sort function shouldn't need to be changed. I think the there should be built-in support for descending instead of having to override the _sort function. |
| @@ -1122,10 +1122,11 @@ Y.ModelList = Y.extend(ModelList, Y.Base, { | |||
| @method _sort | |||
| @param {Model} a First model to compare. | |||
| @param {Model} b Second model to compare. | |||
| @param {Object} [options] Options passed from `sort()` function. | |||
There was a problem hiding this comment.
Should probably document the options param on the sort() method as well.
|
This was me that suggested that it should be more abstract :) @mridgway good point, seems good to have a |
|
@rishabhm thanks! I'll get this merged in now… |
ghost
assigned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1004