Ensure req.params is correctly populated for Routers with a non-default root path. #1207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lt root path (i.e. more than just "/" e.g. "/foo/").
|
Ah yes! Great catch, and thanks for the PR with tests! I'll merge it tomorrow in the AM. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found what I believe to be a bug after pulling down the changes in #1198 where the route regex's aren't correctly matched (and hence the req.params aren't correctly populated) if the Router has a non-default root path. This was because the route regex is run over the full path being dispatched rather than the rootless path.