Enforce a router's root as its mount point
#1198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enforces routers with a specified `root` to only consider paths as
matching its route handles if that path is semantically within the
router's `root` path. For example:
router.set('root', '/app/');
router.hasRoute('/app/'); // => true
router.hasRoute('/app/foo'); // => true
router.hasRoute('/bar/'); // => false
This change fixes some issues with paths being erroneously considered
matching even when they were not semantically within the router's `root`
path.
The `getPath()` method now returns the _full_ current path, whereas
before it returned the current path relative to the router's `root`.
These changes will break backwards compatibility with some apps, but
fix some fundamental issues with how Y.Router handled `root` paths.
Fixes yui#1083
| @@ -482,7 +555,7 @@ routerSuite.add(new Y.Test.Case({ | |||
|
|
|||
| router.route('/hashpath', function (req) { | |||
| test.resume(function () { | |||
| Assert.areSame('/hashpath', req.path); | |||
| Assert.areSame('/foo/hashpath', req.path); | |||
There was a problem hiding this comment.
Changed test's expected value because req.path now contains the full URL, and is no longer relative to the router's root.
|
Looks good to me. Let's be sure to call out the backcompat breakage with |
|
👍 I love this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enforces routers with a specified
rootto only consider paths as matching its route handles if that path is semantically within the router'srootpath. For example:This change fixes some issues with paths being erroneously considered matching even when they were not semantically within the router's
rootpath.The
getPath()method now returns the full current path, whereas before it returned the current path relative to the router'sroot. This mean thatreq.pathis now the full path and is no long relative to the router'sroot.These changes will break backwards compatibility with some apps, but fix some fundamental issues with how Y.Router handled
rootpaths.Fixes #1083