Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sortable module - zIndex of 999 is kept on dragged item #1486

Merged
merged 2 commits into from Mar 25, 2014

Conversation

paulRbr
Copy link
Contributor

@paulRbr paulRbr commented Dec 12, 2013

Hello!

In our project we came across this bug (or maybe is it a feature?) :

  • If we drag an element from a sortable list, the last dragged item keeps a z-index property of 999.
  • Then if we later have a panel shown on top of the page (with a lower z-index of 999) the last dragged item will be in front of the given panel, which is clearly not wanted.

Here is then a PR containing a potential fix. Please give me a feedback whether this is acceptable or not.

Cheers,
Paul

@F21
Copy link

F21 commented Feb 26, 2014

Any chance this can be merged? We are also seeing this as well.

@okuryu
Copy link
Member

okuryu commented Mar 7, 2014

This looks good to me.

ping @lsmith @rgrove @ericf

@okuryu okuryu self-assigned this Mar 18, 2014
@okuryu okuryu added this to the Sprint 13 milestone Mar 18, 2014
@okuryu
Copy link
Member

okuryu commented Mar 20, 2014

I'd like to merge this when get +1 from a reviewer or after 72 hours (excludes holidays).

@okuryu okuryu merged commit d8a2dd4 into yui:dev-master Mar 25, 2014
@okuryu okuryu removed the 3 - Review label Mar 25, 2014
@okuryu
Copy link
Member

okuryu commented Mar 25, 2014

Merged. I believe this will be available in the next release as scheduled in our development schedule.

@paulRbr
Copy link
Contributor Author

paulRbr commented Mar 25, 2014

Cheers, we are needing this in our product. So we'll be able to remove the monkey patch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants