(WIP) Graphics - add ellipticalArc method #1544
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified: js/CanvasDrawing.js modified: js/SVGDrawing.js modified: js/VMLDrawing.js
|
|
||
| //step 1: compute x and y derivatives | ||
| x1_ = (cosTheta * (x1 - x2)/2) + (sinTheta * (y1 - y2)/2); | ||
| y1_ = (-sinTheta * (x1 - x2)/2) + (cosTheta * (y1 - y2)/2); |
There was a problem hiding this comment.
Lines 321-322:
You don't have to divide by 2 twice. Factor it out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First pass at fixing #1443.
Created ellipticalArc method based on w3c elliptical arc implementation notes.
Added manual example based on this example in the path spec.
Currently, VML/Canvas implementations are drawing arcs by point. May consider using cubic bezier approximations depending on performance.