Fix dd in ie6, 7 #1972
Merged
Fix dd in ie6, 7 #1972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified: js/drag.js
|
CLA is valid! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1971
This pull request rolls back #1831 which breaks dd in ie 6 and 7.
As I understand it, the #1831 fix addresses an edge case in panel while breaking core functionality in dd.
In my testing, the edge case was only fixed in chrome and safari, I could still get past modal in firefox.
Additionally, the steps taken to reproduce the panel issue completely break panel in ie 6 - 10. This is not addressed.
@ispyinternet
@andrewnicols
Please chime in if I'm missing something. Thanks.