Support customizable prefix for getSkinName #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sdesai
commented
Jan 8, 2013
sdesai
commented
- Derived from Update Widget.getSkinName() to allow multiple skin prefixes #327, submitted by @aversini
- Submitting to dev-3.x, since it's new feature support for a core component and so that it gets some preview coverage since I'm not monitoring YUI day-to-day.
- All widget unit tests pass. All slider unit tests pass also, as do slider example tests [ slider is the only thing which uses getSkinName currently AFAIK ].
- Main src file change: https://github.com/yui/yui3/pull/397/files#diff-5 (wasn't sure if we still commit build files or not so they're in the pull request)
|
This looks good, @sdesai do you want to merge this in or should I? |
|
Should I be concerned about the failing travis tests on NodeJS 0.8, 0.9? Seem unrelated. |
|
They are Travis/Github issues, as long as |
|
widget tests are all passing on Chrome/Firefox/Safari/IE/iOS, but I have one getSkinName test (related to class names on body) failing in phantomjs. Figuring it's something phantomjs specific, since it looks good in the browsers with heads but I'll look into it before merging - maybe something more robust we can do with the tests, to avoid the phantomjs caveat. |
The class names didn't match the assertions. Moved all the classnames to be dynamic instead of the static + dynamic, which was getting confusing to maintain. Passes on FF, Chrome, Safari, IE, PhantomJS NOTE: Ideally, want to update the test page to follow the latest pattern, with test-console, but that's a separate commit.
Conflicts: src/widget/HISTORY.md
|
This is ready to merge, post-release (it's too late for this current release) |
|
These failures seem unrelated. Tests pass locally for me |
sdesai
added a commit
that referenced
this pull request
Mar 14, 2013
Support customizable prefix for getSkinName
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.