Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support customizable prefix for getSkinName #397

Merged
merged 7 commits into from
Mar 14, 2013
Merged

Support customizable prefix for getSkinName #397

merged 7 commits into from
Mar 14, 2013

Commits on Dec 22, 2012

  1. Added custom prefix support for widget getSkinName

    @sdesai
    sdesai committed Dec 22, 2012
    Configuration menu
    Copy the full SHA
    840e38b View commit details
    Browse the repository at this point in the history

  2. Build for widget getSkinName custom prefix support

    @sdesai
    sdesai committed Dec 22, 2012
    Configuration menu
    Copy the full SHA
    7b02eb3 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2013

  1. Added missing semi-colon

    @sdesai
    sdesai committed Jan 8, 2013
    Configuration menu
    Copy the full SHA
    90cc6d0 View commit details
    Browse the repository at this point in the history

  2. Build for widget skin missing semi-colon

    @sdesai
    sdesai committed Jan 8, 2013
    Configuration menu
    Copy the full SHA
    7d4e38e View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2013

  1. Fixed bad getSkinName test, showing up as a failure on phantomjs 

    The class names didn't match the assertions. Moved all the classnames
to be dynamic instead of the static + dynamic, which was getting
confusing to maintain.

Passes on FF, Chrome, Safari, IE, PhantomJS

NOTE: Ideally, want to update the test page to follow the latest
pattern, with test-console, but that's a separate commit.
    @sdesai
    sdesai committed Feb 21, 2013
    Configuration menu
    Copy the full SHA
    1768050 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'dev-3.x' into getSkinName-Prefix 

    Conflicts:
	src/widget/HISTORY.md
    @sdesai
    sdesai committed Feb 21, 2013
    Configuration menu
    Copy the full SHA
    f99d80e View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2013

  1. Merged in latest dev-3.x, fixed HISTORY.md conflict

    @sdesai
    sdesai committed Mar 14, 2013
    Configuration menu
    Copy the full SHA
    0120244 View commit details
    Browse the repository at this point in the history