improvements to DataType.Date.parse #71
Conversation
curtisharvey
commented
Jan 20, 2012
curtisharvey
commented
- return Date object when passed one (fixes #2530058, closes #2530059)
- accept timestamp as number or string
- remove obsolete workaround in validation
- return Date object when passed one (fixes #2530058, closes #2530059) - accept timestamp as number or string - remove obsolete workaround in validation
ghost
assigned 
|
Is there any update here? Having improved and sensible date parsing would be nice. |
|
👍 |
|
The Datatype.Date revamp is on my list for the next 3.6.x release. I might be able to fix the parse bugs in the current 3.6.x sprint, as long as it doesn't interfere with future changes. |
|
Unfortunately, nothing changed in the parse functionality in this release (DataType.Date did get moved to just Y.Date, though). But I am working with an external contributor for the next release, and this pull request will definitely be addressed within the next month. Thanks! |
|
Hi, @curtisharvey. Our apologies for a long delay on this. I would like to get this functionality in, but there are a couple of issues:
Would you like to do those things and open a new pull request? This time I promise that we'll take care of it on the order of days, not months. I completely understand if you've moved on from this though, and can do these things myself if you are no longer available. Thanks! |
|
Sorry, been super busy of late, but I will take a look at this now and try to get a updated pull request out shortly. |
…atatype-date-parse * upstream/master: (4186 commits) Build files for calendar chainable methods Build Node. No -min changes. Clarified possible return of null from node.one() Build DataTable. Build QueryString. No -min changes. Fix QueryString's API Docs. cleaned up whitespace Added assertions for @chainable methods in calendar Fixed CLI test when run in full batch experimenting with Dial performance test writting Seed build Changed to Function constructor call Updated md5 sum helper meta-join script updates Made public CalendarBase and Calendar methods chainable Also fixed a little bit of whitespace Seed and Loader build for #2532889 Gallery version bump Added tests for #2532889 Added Y.config.global, fixes #2532889 More Builder -> Shifter docs replacement ...
Needed to cleanup and reapply date parse improvements after files have moved since pull request was first made. Also upgraded tests to both fix an incorrect assertion and test new functionality in Y.Date.parse.
|
Thanks for your contribution, @curtisharvey. I have pulled this in, and the pull request will be closed automatically in short order. |
