Make sure that cli exits properly, fixes #23

yui · Apr 2, 2013 · 0fd982c · 0fd982c
1 parent 9f86ac4
commit 0fd982c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 10 deletions.
diff --git a/javascript/src/cli/CLI-common.js b/javascript/src/cli/CLI-common.js
@@ -107,6 +107,9 @@ YUITest.Util.mix(YUITest.CLI, {
 
         this.processArguments();
         this.processFiles();
+        YUITest.TestRunner.subscribe(YUITest.TestRunner.COMPLETE_EVENT, function(event) {
+            YUITest.CLI.quit(event.results.failed ? 1 : 0);
+        });
 
         YUITest.TestRunner.run({
             groups: this.options.groups ? this.options.groups.split(",") : null

diff --git a/javascript/src/cli/CLI-node.js b/javascript/src/cli/CLI-node.js
@@ -42,16 +42,7 @@ YUITest.CLI = {
     },
 
     quit: function(code){
-
-        //Workaround for https://github.com/joyent/node/issues/1669
-        var flushed = process.stdout.flush && process.stdout.flush();
-        if (!flushed && (parseFloat(process.versions.node) < 0.5)) {
-            process.once("drain", function () {
-                process.exit(code || 0);
-            });
-        } else {
-            process.exit(code || 0);
-        }
+        process.exit(code || 0);
     },
 
     isDirectory: function(name) {