Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require a space after : for definition list #15

Closed
wants to merge 3 commits into from

Conversation

litao91
Copy link

@litao91 litao91 commented Jul 15, 2019

Hello
:Word 

Will cause panic

@yuin
Copy link
Owner

yuin commented Jul 15, 2019

Thanks for your PR.
"Space" in CommonMark is not only spaces but tabs.

term
:[space][space][space]definition1
[space][space][space][space]definition2

->

<dl>
<dt>term</dt>
<dd>definition
definition2</dd>
</dl>
term
:[space][space][space]definition1
[space][space][space][space][space]definition2

->

<dl>
<dt>term</dt>
<dd>definition
[space]definition2</dd>
</dl>
term
:[TAB]definition1
[space][space][space][space]definition2

->

<dl>
<dt>term</dt>
<dd>definition
definition2</dd>
</dl>
term
:[TAB][TAB]definition1
[space][space][space][space][space][space][space][space]definition2

->

<dl>
<dt>term</dt>
<dd><pre><code>definition1
definition2
</code></pre></dd>
</dl>

If you feel hard to fix the issue, could you submit a issue to this project?
I'll fix the issue as quick as I can.

@yuin
Copy link
Owner

yuin commented Jul 24, 2019

I've fixed this bug while fixing bugs found in fuzzing. Thanks for your efforts!

@yuin yuin closed this Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants